Nuria has submitted this change and it was merged.
Change subject: Remove invalid user count in cohort detail
......................................................................
Remove invalid user count in cohort detail
When the cohort has no invalid users, do
not show the 'N are invalid' message.
Change-Id: I5126a98355856e4a194d0a2d164cdea1f2c210e0
---
M wikimetrics/templates/cohorts.html
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Nuria: Looks good to me, approved
diff --git a/wikimetrics/templates/cohorts.html
b/wikimetrics/templates/cohorts.html
index 0c85213..4786e5a 100644
--- a/wikimetrics/templates/cohorts.html
+++ b/wikimetrics/templates/cohorts.html
@@ -51,10 +51,9 @@
Validated
<span data-bind="text: validated_count"></span> of
<span data-bind="text: total_count"></span> cohort
members.
- <span data-bind="text: valid_count"></span> are
valid,
- <a data-bind="attr: {href:
'/cohorts/detail/invalid-users/' + id}" target="_blank">
- <span data-bind="text: invalid_count"></span>
are invalid.
- </a>
+ <span data-bind="text: valid_count"></span> are
valid<span data-bind="if: invalid_count">,
+ <a data-bind="attr: {href:
'/cohorts/detail/invalid-users/' + id}" target="_blank">
+ <span data-bind="text:
invalid_count"></span> are invalid</a></span>.
</p>
</div>
</div>
--
To view, visit https://gerrit.wikimedia.org/r/165766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5126a98355856e4a194d0a2d164cdea1f2c210e0
Gerrit-PatchSet: 3
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Mforns <[email protected]>
Gerrit-Reviewer: Nuria <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
