jenkins-bot has submitted this change and it was merged.

Change subject: Set initial keyboard height
......................................................................


Set initial keyboard height

Undefined keyboard height results in NaN when doing math operations on
it.

Change-Id: Ic27bf2f2611e7df95cccf04c4d5a64f9eaebbb64
---
M javascripts/Overlay.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/javascripts/Overlay.js b/javascripts/Overlay.js
index aca968f..00a467a 100644
--- a/javascripts/Overlay.js
+++ b/javascripts/Overlay.js
@@ -214,7 +214,7 @@
                                $( el )
                                        .on( 'focus', function() {
                                                setTimeout( function() {
-                                                       var keyboardHeight;
+                                                       var keyboardHeight = 0;
 
                                                        // detect virtual 
keyboard height
                                                        if ( !M.isIos8 ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/165769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic27bf2f2611e7df95cccf04c4d5a64f9eaebbb64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to