jenkins-bot has submitted this change and it was merged.
Change subject: Cleanup previous EntityIdParser cleanup
......................................................................
Cleanup previous EntityIdParser cleanup
This fixes some minor details introduced in Ie6cc3dd.
Change-Id: Ib3565635f0e5d86b51b36a1dd409cc1c36d44d6e
---
M repo/includes/api/ModifyEntity.php
M repo/includes/specials/SpecialSetSiteLink.php
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Bene: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/api/ModifyEntity.php
b/repo/includes/api/ModifyEntity.php
index 7008013..7fd5b53 100644
--- a/repo/includes/api/ModifyEntity.php
+++ b/repo/includes/api/ModifyEntity.php
@@ -21,7 +21,6 @@
use Wikibase\Repo\WikibaseRepo;
use Wikibase\StringNormalizer;
use Wikibase\Summary;
-use WikiPage;
/**
* Base class for API modules modifying a single entity identified based on id
xor a combination of site and page title.
@@ -197,7 +196,7 @@
foreach ( $badgesParams as $badgeSerialization ) {
try {
$badgeId = new ItemId( $badgeSerialization );
- } catch( InvalidArgumentException $e ) {
+ } catch ( InvalidArgumentException $ex ) {
$this->dieError( 'Badges: could not parse "' .
$badgeSerialization
. '", the id is invalid',
'invalid-entity-id' );
continue;
diff --git a/repo/includes/specials/SpecialSetSiteLink.php
b/repo/includes/specials/SpecialSetSiteLink.php
index d2eadb3..84e5c36 100644
--- a/repo/includes/specials/SpecialSetSiteLink.php
+++ b/repo/includes/specials/SpecialSetSiteLink.php
@@ -3,6 +3,7 @@
namespace Wikibase\Repo\Specials;
use Html;
+use InvalidArgumentException;
use OutOfBoundsException;
use Status;
use Wikibase\ChangeOp\ChangeOpException;
@@ -10,7 +11,6 @@
use Wikibase\CopyrightMessageBuilder;
use Wikibase\DataModel\Entity\Entity;
use Wikibase\DataModel\Entity\EntityId;
-use Wikibase\DataModel\Entity\EntityIdParsingException;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\Repo\WikibaseRepo;
--
To view, visit https://gerrit.wikimedia.org/r/166385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3565635f0e5d86b51b36a1dd409cc1c36d44d6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Bene <benestar.wikime...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
