Matthias Mullie has submitted this change and it was merged.
Change subject: Hygiene: Ensure property is set before accessing
......................................................................
Hygiene: Ensure property is set before accessing
Change-Id: I1f885a195139311d695ef20f0cb572a7f6c40bed
---
M includes/Notifications/Formatter.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Notifications/Formatter.php
b/includes/Notifications/Formatter.php
index c56c49b..5b30a2f 100644
--- a/includes/Notifications/Formatter.php
+++ b/includes/Notifications/Formatter.php
@@ -179,7 +179,7 @@
// merged, $data should be always an instance of
EchoEvent
if ( $data instanceof \EchoEvent ) {
$extra = $data->getExtra();
- } else {
+ } elseif ( isset( $data->event_extra ) ) {
$extra = $data->event_extra;
}
if ( isset( $extra['post-id'] ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/165882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f885a195139311d695ef20f0cb572a7f6c40bed
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: SG <shah...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
