Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167175
Change subject: Remove slashes from HTML elements that aren't allowed to be
empty
......................................................................
Remove slashes from HTML elements that aren't allowed to be empty
I tried, but after looking at these for almost a year now I still
find these counter-intuitive, confusing and just unnecesarry.
1. Look at the jQuery code. All it does is just ignoring these
slashes. They don't do anything.
2. These elements are not allowed to be empty. Linters/hinters like
PHPStorm keep complaining about this, decreasing the value of
these tools.
3. Even our own code base is not consistent. A lot of instances
don't use slashes, even for empty elements like <br> or <input>
(which I fixed in I87d0c53).
Change-Id: I0bec09777289beb2bd9c05315fb26b19f09009a9
---
M lib/resources/jquery.ui/jquery.ui.tagadata.js
M lib/resources/jquery.wikibase/jquery.wikibase.aliasesview.js
M lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
M lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplistview.js
M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
M lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
M lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
M lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
M lib/resources/jquery.wikibase/jquery.wikibase.fingerprintgroupview.js
M lib/resources/jquery.wikibase/jquery.wikibase.fingerprintview.js
M lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
M lib/resources/jquery.wikibase/jquery.wikibase.listview.js
M lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
M lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.js
M lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgroupview.js
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.RankSelector.js
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
M lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
M lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
M lib/resources/jquery.wikibase/snakview/snakview.js
M lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
M lib/resources/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.js
M lib/resources/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.js
M lib/resources/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.js
M lib/resources/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.js
M lib/resources/templates.js
M lib/resources/wikibase.Site.js
M lib/resources/wikibase.utilities/wikibase.utilities.ui.js
M lib/tests/qunit/jquery.ui/jquery.ui.tagadata.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.badgeselector.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
M
lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbaritem.tests.js
M lib/tests/qunit/jquery/jquery.removeClassByRegex.tests.js
M lib/tests/qunit/templates.tests.js
M repo/resources/wikibase.ui.entityViewInit.js
M repo/resources/wikibase.ui.entitysearch.js
59 files changed, 126 insertions(+), 126 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/75/167175/1
diff --git a/lib/resources/jquery.ui/jquery.ui.tagadata.js
b/lib/resources/jquery.ui/jquery.ui.tagadata.js
index 95c9dca..26714f7 100644
--- a/lib/resources/jquery.ui/jquery.ui.tagadata.js
+++ b/lib/resources/jquery.ui/jquery.ui.tagadata.js
@@ -306,7 +306,7 @@
return $tag;
}
- var $label = $( '<span/>' ).addClass( 'tagadata-label' ),
+ var $label = $( '<span>' ).addClass( 'tagadata-label' ),
$input = $( '<input />' ).attr( 'name',
this.options.itemName + '[]' );
$tag = this._createTagNode().addClass( additionalClasses || ''
).append( $label );
@@ -354,7 +354,7 @@
var $removeTag = $( '<a><span
class="text-icon">\xd7</span></a>' )// \xd7 is an X
.addClass( 'tagadata-close' )
- .append( $( '<span/>' ).addClass( 'ui-icon
ui-icon-close' ) )
+ .append( $( '<span>' ).addClass( 'ui-icon
ui-icon-close' ) )
.click( function() {
if( !self.option( 'disabled' ) ) {
self.removeTag( $tag );
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.aliasesview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.aliasesview.js
index 058cc26..7e39911 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.aliasesview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.aliasesview.js
@@ -451,7 +451,7 @@
$container = $aliasesview.find( 'ul' ).next(
'span' );
if( !$container.length ) {
- $container = $( '<span/>' ).insertAfter(
$aliasesview.find( 'ul' ) );
+ $container = $( '<span>' ).insertAfter(
$aliasesview.find( 'ul' ) );
}
$aliasesview.edittoolbar( {
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
index 31db028..5cd1c32 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.badgeselector.js
@@ -219,7 +219,7 @@
return $menu;
}
- $menu = $( '<ul/>' )
+ $menu = $( '<ul>' )
.text( '...' )
.addClass( this.widgetBaseClass + '-menu' )
.appendTo( 'body' );
@@ -282,7 +282,7 @@
$.each( self.options.badges, function( itemId,
cssClasses ) {
var item = badges[itemId];
- var $item = $( '<a/>' )
+ var $item = $( '<a>' )
.on( 'click.' + self.widgetName,
function( event ) {
event.preventDefault();
} );
@@ -295,7 +295,7 @@
);
}
- $( '<li/>' )
+ $( '<li>' )
.addClass( self.widgetBaseClass + '-menuitem-'
+ itemId )
.data( self.widgetName + '-menuitem-badge',
itemId )
.append( $item
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplistview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplistview.js
index 00dc9d6..c010df1 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplistview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplistview.js
@@ -371,7 +371,7 @@
claimgrouplistview = $claimgrouplistview.data(
'claimgrouplistview' );
$claimgrouplistview.addtoolbar( {
- $container: $( '<div/>' ).appendTo(
$claimgrouplistview )
+ $container: $( '<div>' ).appendTo(
$claimgrouplistview )
} )
.on( 'addtoolbaradd.addtoolbar', function( e ) {
if( e.target !== $claimgrouplistview.get( 0 ) )
{
@@ -433,7 +433,7 @@
}
$claimview.movetoolbar( {
- $container: $( '<div/>' ).appendTo( $claimview )
+ $container: $( '<div>' ).appendTo( $claimview )
} );
// If the claimview is the topmost claimview in the
topmost claimgroup, the "move up"
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
index 18abca2..ac743d9 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
@@ -412,7 +412,7 @@
if( !$container.length ) {
// TODO: Remove layout-specific toolbar wrapper
- $container = $( '<div/>' ).appendTo(
+ $container = $( '<div>' ).appendTo(
mw.template(
'wikibase-toolbar-wrapper', '' ).appendTo( $claimlistview )
);
}
@@ -476,7 +476,7 @@
$container = $view.children(
'.wikibase-toolbar-container' );
if( !$container.length ) {
- $container = $( '<div/>' ).appendTo( $view );
+ $container = $( '<div>' ).appendTo( $view );
}
options.$container = $container;
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
index 832d0ad..4dbe2be 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
@@ -78,7 +78,7 @@
return ( this._claim && this._claim.getGuid() )
|| 'new';
},
function() {
- return $( '<div/>' );
+ return $( '<div>' );
}, // .wb-claim-mainsnak
'' // Qualifiers
],
@@ -239,7 +239,7 @@
// snaklistviews are managed in a listview:
var $qualifiers = this.$qualifiers.children();
if( !$qualifiers.length ) {
- $qualifiers = $( '<div/>' ).prependTo( this.$qualifiers
);
+ $qualifiers = $( '<div>' ).prependTo( this.$qualifiers
);
}
$qualifiers.listview( {
listItemAdapter: new
$.wikibase.listview.ListItemAdapter( {
@@ -771,7 +771,7 @@
) {
$qualifiers
.addtoolbar( {
- $container: $( '<div/>' ).appendTo(
$qualifiers ),
+ $container: $( '<div>' ).appendTo(
$qualifiers ),
label: mw.msg( 'wikibase-addqualifier' )
} )
.off( '.addtoolbar' )
@@ -894,7 +894,7 @@
// Create toolbar for each snakview widget:
$snakview
.removetoolbar( {
- $container: $( '<div/>' ).appendTo( $snakview )
+ $container: $( '<div>' ).appendTo( $snakview )
} )
.on( 'removetoolbarremove.removetoolbar', function(
event ) {
if( event.target === $snakview.get( 0 ) ) {
@@ -983,7 +983,7 @@
if( $snaklistview.data( 'snaklistview' ).value() !==
null ) {
// Create toolbar for each snakview widget:
$snakview.movetoolbar( {
- $container: $( '<div/>' ).appendTo(
$snakview )
+ $container: $( '<div>' ).appendTo(
$snakview )
} );
var $topMostSnakview =
listview.items().first().data( 'snaklistview' )
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
index 23a9a5f..e1104cc 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js
@@ -383,7 +383,7 @@
$container = $descriptionview.find(
'.wikibase-toolbar-container' );
if( !$container.length ) {
- $container = $( '<span/>' ).appendTo(
+ $container = $( '<span>' ).appendTo(
$descriptionview.find(
'.wikibase-descriptionview-container' )
);
}
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
index c5c42a4..46cadca 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
@@ -250,16 +250,16 @@
* @return {jQuery}
*/
_createLabelFromSuggestion: function( entityStub ) {
- var $suggestion = $( '<span
class="ui-entityselector-itemcontent"/>' );
+ var $suggestion = $( '<span
class="ui-entityselector-itemcontent">' );
$suggestion.append(
- $( '<span
class="ui-entityselector-label"/>' )
+ $( '<span
class="ui-entityselector-label">' )
.text( entityStub.label ||
entityStub.id )
);
if( entityStub.description ) {
$suggestion.append(
- $( '<span
class="ui-entityselector-description"/>' )
+ $( '<span
class="ui-entityselector-description">' )
.text( entityStub.description )
);
}
@@ -270,7 +270,7 @@
+ entityStub.aliases.join( ', ' );
$suggestion.append(
- $( '<span
class="ui-entityselector-aliases"/>' ).text( aliasesText )
+ $( '<span
class="ui-entityselector-aliases">' ).text( aliasesText )
);
}
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
index 1272bd6..6a27b81 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
@@ -114,7 +114,7 @@
if( !this.$label.length ) {
this.$label = mw.template( 'wikibase-h1',
this.options.value.getId(),
- $( '<div/>' )
+ $( '<div>' )
).appendTo( this.element );
}
@@ -139,7 +139,7 @@
_initDescription: function() {
this.$description = $( '.wikibase-descriptionview',
this.element ).first();
if( !this.$description.length ) {
- this.$description = $( '<div/>' ).appendTo(
this.element );
+ this.$description = $( '<div>' ).appendTo( this.element
);
}
this.$description.descriptionview( {
@@ -162,7 +162,7 @@
_initAliases: function() {
this.$aliases = $( '.wikibase-aliasesview', this.element
).first();
if( !this.$aliases.length ) {
- this.$aliases = $( '<div/>' ).appendTo( this.element );
+ this.$aliases = $( '<div>' ).appendTo( this.element );
}
this.$aliases.aliasesview( {
@@ -195,7 +195,7 @@
);
}
- this.$fingerprints = $( '<div/>' ).insertAfter(
$precedingNode );
+ this.$fingerprints = $( '<div>' ).insertAfter(
$precedingNode );
}
var value = [];
@@ -219,7 +219,7 @@
_initClaims: function() {
this.$claims = $( '.wb-claimgrouplistview', this.element
).first();
if( this.$claims.length === 0 ) {
- this.$claims = $( '<div/>' ).appendTo( this.element );
+ this.$claims = $( '<div>' ).appendTo( this.element );
}
this.$claims
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintgroupview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintgroupview.js
index e51fc85..5097e35 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintgroupview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintgroupview.js
@@ -88,7 +88,7 @@
this.$fingerprintlistview = this.element.find(
'.wikibase-fingerprintlistview' );
if( !this.$fingerprintlistview.length ) {
- this.$fingerprintlistview = $( '<table/>' ).appendTo(
this.element );
+ this.$fingerprintlistview = $( '<table>' ).appendTo(
this.element );
}
this._createFingerprintlistview();
@@ -282,7 +282,7 @@
$container = $headingContainer.children(
'.wikibase-toolbar-container' );
if( !$container.length ) {
- $container = $( '<div/>' ).appendTo(
$headingContainer );
+ $container = $( '<div>' ).appendTo(
$headingContainer );
}
$fingerprintgroupview.edittoolbar( {
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintview.js
index 760e06d..0a84334 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintview.js
@@ -173,7 +173,7 @@
self['$' + widgetName] = self['$' +
subjectName].children( '.wikibase-' + widgetName );
if( !self['$' + widgetName].length ) {
- self['$' + widgetName] = $( '<div/>'
).appendTo( self['$' + subjectName] );
+ self['$' + widgetName] = $( '<div>' ).appendTo(
self['$' + subjectName] );
}
// Fully encapsulate child widgets by suppressing their
events:
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
index ff93134..9c814cb 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.labelview.js
@@ -397,7 +397,7 @@
// TODO: Remove toolbar-wrapper that is firstHeading
specific (required to reset font
// size)
if( !$container.length ) {
- $container = $( '<span/>' ).appendTo(
+ $container = $( '<span>' ).appendTo(
mw.template(
'wikibase-toolbar-wrapper', '' )
.appendTo( $labelview.find(
'.wikibase-labelview-container' ) )
);
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.listview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.listview.js
index f5b0d86..1da63ef 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.listview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.listview.js
@@ -190,7 +190,7 @@
// Add new values:
for( var i = 0; i < value.length; i++ ) {
- var $newLi = $( '<' + this.option( 'listItemNodeName' )
+'/>' )
+ var $newLi = $( '<' + this.option( 'listItemNodeName' )
+ '>' )
.addClass( this.widgetName + '-item' );
this.element.append( $newLi );
this._lia.newListItem( $newLi, value[i] );
@@ -329,7 +329,7 @@
if( this._reusedItems.length > 0 ) {
$newLi = $( this._reusedItems.shift() );
} else {
- $newLi = $( '<' + this.option(
'listItemNodeName' ) + '/>' );
+ $newLi = $( '<' + this.option(
'listItemNodeName' ) + '>' );
}
$newLi.addClass( this.widgetName + '-item' );
event.handlerArgs = [ value || null, $newLi ];
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
index 2457bd9..ee801d5 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js
@@ -606,7 +606,7 @@
var $referenceview = $( event.target );
$referenceview.addtoolbar( {
- $container: $( '<div/>' ).appendTo(
$referenceview )
+ $container: $( '<div>' ).appendTo(
$referenceview )
} )
.on( 'addtoolbaradd.addtoolbar', function() {
$referenceview.data( 'referenceview'
).enterNewItem();
@@ -676,7 +676,7 @@
snakviewPropertyGroupListview =
snaklistview._listview;
$target.removetoolbar( {
- $container: $( '<div/>' ).appendTo(
$target )
+ $container: $( '<div>' ).appendTo(
$target )
} )
.on( 'removetoolbarremove.removetoolbar',
function( event ) {
if( event.target === $target.get( 0 ) )
{
@@ -801,7 +801,7 @@
// Since snakviewstartediting is triggered for
every snakview, this creates the
// toolbar for each snakview widget:
$snakview.movetoolbar( {
- $container: $( '<div/>' ).appendTo(
$snakview )
+ $container: $( '<div>' ).appendTo(
$snakview )
} );
// Disable "move up" button of topmost and
"move down" button of bottommost
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.js
index dbcad19..03a2b42 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.js
@@ -78,7 +78,7 @@
this.$listview = this.element.find( '.wb-listview' );
if( !this.$listview.length ) {
- this.$listview = $( '<div/>' ).appendTo( this.element );
+ this.$listview = $( '<div>' ).appendTo( this.element );
}
this.$listview
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgroupview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgroupview.js
index 85450b0..1229382 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgroupview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkgroupview.js
@@ -99,7 +99,7 @@
this.$sitelinklistview = this.element.find(
'.wikibase-sitelinklistview' );
if( !this.$sitelinklistview.length ) {
- this.$sitelinklistview = $( '<table/>' ).appendTo(
this.element );
+ this.$sitelinklistview = $( '<table>' ).appendTo(
this.element );
}
this._createSitelinklistview();
@@ -362,7 +362,7 @@
$container = $headingContainer.children(
'.wikibase-toolbar-container' );
if( !$container.length ) {
- $container = $( '<div/>' ).appendTo(
$headingContainer );
+ $container = $( '<div>' ).appendTo(
$headingContainer );
}
$sitelinkgroupview.edittoolbar( {
@@ -430,7 +430,7 @@
$sitelinklistview
.addtoolbar( {
- $container: $( '<span/>' ).appendTo(
sitelinklistview.$tfoot.find( 'td' ).last() )
+ $container: $( '<span>' ).appendTo(
sitelinklistview.$tfoot.find( 'td' ).last() )
} )
.on( 'addtoolbaradd.addtoolbar', function() {
sitelinklistview.$listview.one(
@@ -520,7 +520,7 @@
$sitelinkview
.removetoolbar( {
- $container: $( '<div/>' ).appendTo(
$sitelinkview.children( 'td' ).last() )
+ $container: $( '<div>' ).appendTo(
$sitelinkview.children( 'td' ).last() )
} )
.on( 'removetoolbarremove.removetoolbar',
function( event ) {
if( event.target !== $sitelinkview.get(
0 ) ) {
@@ -552,7 +552,7 @@
// definition
$sitelinkview
.removetoolbar( {
- $container: $( '<div/>' ).appendTo(
$sitelinkview.children( 'td' ).last() )
+ $container: $( '<div>' ).appendTo(
$sitelinkview.children( 'td' ).last() )
} )
.on( 'removetoolbarremove.removetoolbar',
function( event ) {
if( event.target !== $sitelinkview.get(
0 ) ) {
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.RankSelector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.RankSelector.js
index 7f89e24..d8b9ebf 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.RankSelector.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.RankSelector.js
@@ -165,17 +165,17 @@
*/
_buildMenu: function() {
var self = this,
- $menu = $( '<ul/>' ).addClass(
this.widgetBaseClass + '-menu' );
+ $menu = $( '<ul>' ).addClass(
this.widgetBaseClass + '-menu' );
$.each( wb.datamodel.Statement.RANK, function( rankId,
i ) {
rankId = rankId.toLowerCase();
$menu.append(
- $( '<li/>' )
+ $( '<li>' )
.addClass( self.widgetBaseClass +
'-menuitem-' + rankId )
.data( self.widgetName +
'-menuitem-rank', i )
.append(
- $( '<a/>' )
+ $( '<a>' )
.text( mw.msg(
'wikibase-statementview-rank-' + rankId ) )
.on( 'click.' +
self.widgetName, function( event ) {
event.preventDefault();
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index 609d2db..371331c 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -29,7 +29,7 @@
return ( this._claim && this._claim.getGuid() )
|| 'new';
},
function() {
- return $( '<div/>' );
+ return $( '<div>' );
}, // .wb-claim-mainsnak
'', // Qualifiers
'', // TODO: This toolbar placeholder should be removed
from the template.
@@ -77,7 +77,7 @@
if( this.value() ) {
var $listview = this.$references.children();
if( !$listview.length ) {
- $listview = $( '<div/>' ).prependTo(
this.$references );
+ $listview = $( '<div>' ).prependTo(
this.$references );
}
$listview.listview( {
@@ -157,7 +157,7 @@
}
// toggle for references section:
- var $toggler = $( '<a/>' ).toggler( { $subject:
this.$references } );
+ var $toggler = $( '<a>' ).toggler( { $subject:
this.$references } );
if( this.$refsHeading.text() ) {
$toggler.find( '.ui-toggler-label' ).text(
this.$refsHeading.text() );
@@ -431,7 +431,7 @@
$node
.addtoolbar( {
- $container: $( '<div/>' ).appendTo( $node ),
+ $container: $( '<div>' ).appendTo( $node ),
label: mw.msg( 'wikibase-addreference' )
} )
.on( 'addtoolbaradd.addtoolbar', function( e ) {
@@ -498,7 +498,7 @@
$container = $referenceview.find(
'.wikibase-toolbar-container' );
if( !$container.length ) {
- $container = $( '<div/>' ).appendTo(
+ $container = $( '<div>' ).appendTo(
$referenceview.find(
'.wb-referenceview-heading' )
);
}
@@ -570,7 +570,7 @@
}
$referenceview.movetoolbar( {
- $container: $( '<div/>' ).appendTo(
$referenceview )
+ $container: $( '<div>' ).appendTo(
$referenceview )
} );
// Disable "move up" button of topmost and "move down"
button of bottommost
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
b/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
index 7d3d96f..b0e6c4e 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
@@ -283,21 +283,21 @@
* @TODO: Error tooltip should be a separate tooltip derivative.
*/
_buildErrorTooltip: function() {
- var $message = $( '<div/>' ).addClass( 'wb-error ' +
this.widgetFullName + '-error' );
+ var $message = $( '<div>' ).addClass( 'wb-error ' +
this.widgetFullName + '-error' );
- var $mainMessage = $( '<div/>' ).text(
this.options.content.message ).appendTo( $message );
+ var $mainMessage = $( '<div>' ).text(
this.options.content.message ).appendTo( $message );
// Append detailed error message if given; hide it behind
toggle:
if( this.options.content.detailedMessage ) {
$mainMessage.addClass( this.widgetFullName +
'-error-top-message' );
- var $detailedMessage = $( '<div/>', {
+ var $detailedMessage = $( '<div>', {
'class': this.widgetFullName + '-error-details',
html: this.options.content.detailedMessage
} )
.hide();
- var $toggler = $( '<a/>' )
+ var $toggler = $( '<a>' )
.addClass( this.widgetFullName +
'-error-details-link' )
.text( mw.msg( 'wikibase-tooltip-error-details'
) )
.toggler( { $subject: $detailedMessage,
duration: 'fast' } );
diff --git
a/lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
b/lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
index 1df67eb..b79c7db 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
@@ -106,7 +106,7 @@
$( window ).on( 'resize.' + widgetName, degrade
);
} );
- this.$icon = $( '<span/>' )
+ this.$icon = $( '<span>' )
.addClass( 'ui-icon ui-icon-snaktypeselector' )
.appendTo( this.element );
@@ -175,15 +175,15 @@
*/
_buildMenu: function() {
var classPrefix = this.widgetBaseClass + '-menuitem-',
- $menu = $( '<ul/>' ).addClass(
this.widgetBaseClass + '-menu' ),
+ $menu = $( '<ul>' ).addClass(
this.widgetBaseClass + '-menu' ),
snakTypes =
$.wikibase.snakview.variations.getCoveredSnakTypes();
$.each( snakTypes, function( i, type ) {
$menu.append(
- $( '<li/>' )
+ $( '<li>' )
.addClass( classPrefix + type ) // type
should only be lower case string anyhow!
.data(
'snaktypeselector-menuitem-type', type )
- .append( $( '<a/>' ).attr( 'href',
'javascript:void(0);' ).text(
+ .append( $( '<a>' ).attr( 'href',
'javascript:void(0);' ).text(
mw.msg(
'wikibase-snakview-snaktypeselector-' + type )
) )
);
diff --git a/lib/resources/jquery.wikibase/snakview/snakview.js
b/lib/resources/jquery.wikibase/snakview/snakview.js
index bb7450d..7a5df3a 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.js
@@ -241,7 +241,7 @@
self.propertyId( null );
self.$snakValue.empty().append(
- $( '<div/>' ).append( $( '<span/>'
).addClass( 'mw-small-spinner' ) )
+ $( '<div>' ).append( $( '<span>'
).addClass( 'mw-small-spinner' ) )
);
}
@@ -819,7 +819,7 @@
if( propertyId ) {
// property ID selected but apparently no
variation available to handle it
- $( '<span/>' ).text( mw.msg(
'wikibase-snakview-choosesnaktype' ) )
+ $( '<span>' ).text( mw.msg(
'wikibase-snakview-choosesnaktype' ) )
.addClass( this.widgetBaseClass +
'-unsupportedsnaktype' )
.appendTo( this.$snakValue );
// NOTE: instead of doing this here and
checking everywhere whether this._variation
@@ -838,7 +838,7 @@
*/
_buildSnakTypeSelector: function() {
var self = this,
- $anchor = $( '<span/>' ),
+ $anchor = $( '<span>' ),
// initiate snak type selector widget which is a normal
widget just without a
// jQuery.widget.bridge...
selector = new $.wikibase.snakview.SnakTypeSelector(
{}, $anchor );
diff --git
a/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
b/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
index 7b593c9..1fb7d69 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
@@ -133,14 +133,14 @@
self._valueView = null;
}
self.$viewPort.empty().append(
- $( '<div/>', {
+ $( '<div>', {
'class':
self.variationBaseClass + '-datavaluetypemismatch-message',
text: mw.msg(
'wikibase-snakview-variation-datavaluetypemismatch',
actualDataValueType, intendedDataValueType
)
} )
- .append( $( '<div/>', {
+ .append( $( '<div>', {
text: mw.msg(
'wikibase-snakview-variation-datavaluetypemismatch-details',
actualDataValueType, intendedDataValueType )
@@ -300,7 +300,7 @@
this._valueView = null;
this.$viewPort.empty();
}
- $valueViewDom = this.$viewPort.wrapInner( '<div/>'
).children();
+ $valueViewDom = this.$viewPort.wrapInner( '<div>'
).children();
// Can't choose a view for displaying empty value
without indication by data type
// definition which kind of value should be creatable
by the new valueview.
diff --git
a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.js
b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.js
index 23d0766..94e33aa 100644
--- a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.js
+++ b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.js
@@ -49,7 +49,7 @@
_createDefaultButton: function() {
var self = this;
- return $( '<span/>' ).toolbarbutton( {
+ return $( '<span>' ).toolbarbutton( {
$label: this.options.label,
cssClassSuffix: 'add'
} )
diff --git
a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.js
b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.js
index 9a09df2..f805e3d 100644
--- a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.js
+++ b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.js
@@ -156,14 +156,14 @@
$toolbar = $container.children( '.wikibase-toolbar' );
if( !$toolbar.length ) {
- $toolbar = $( '<span/>' ).appendTo( $container );
+ $toolbar = $( '<span>' ).appendTo( $container );
}
$toolbar.toolbar( {
renderItemSeparators: true
} );
- this._$tooltipAnchor = $( '<span/>', {
+ this._$tooltipAnchor = $( '<span>', {
'class': 'mw-help-field-hint',
style:
'display:inline-block;text-decoration:none;width:8px;', // TODO: Get rid of
inline styles.
html: ' ' // TODO find nicer way to hack Webkit
browsers to display tooltip image (see also css)
@@ -350,7 +350,7 @@
*/
getButton: function( buttonName ) {
if( !this._buttons[buttonName] ) {
- this._buttons[buttonName] = $( '<span/>'
).toolbarbutton( {
+ this._buttons[buttonName] = $( '<span>'
).toolbarbutton( {
$label: this.options.buttonLabels[buttonName],
cssClassSuffix: buttonName
} );
@@ -392,7 +392,7 @@
} else {
$container.contents().hide();
- $actionMsg = $( '<span/>' )
+ $actionMsg = $( '<span>' )
.addClass( actionMessageClass + ' wb-actionmsg'
)
.text( messageOrCallback )
.appendTo( $container )
diff --git
a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.js
b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.js
index 6d6b3a3..f3a6b65 100644
--- a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.js
+++ b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.js
@@ -53,8 +53,8 @@
_createDefaultButton: function( direction ) {
var self = this;
- this._buttons[direction] = $( '<span/>' ).toolbarbutton( {
- $label: $( '<span/>', {
+ this._buttons[direction] = $( '<span>' ).toolbarbutton( {
+ $label: $( '<span>', {
title: mw.msg( 'wikibase-move-' + direction ),
'class': 'ui-icon '
+ ( direction === 'up' ?
'ui-icon-triangle-1-n' : 'ui-icon-triangle-1-s' )
diff --git
a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.js
b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.js
index 16a16e8..5df9560 100644
--- a/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.js
+++ b/lib/resources/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.js
@@ -49,7 +49,7 @@
_createDefaultButton: function() {
var self = this;
- return $( '<span/>' ).toolbarbutton( {
+ return $( '<span>' ).toolbarbutton( {
$label: this.options.label,
cssClassSuffix: 'remove'
} )
diff --git a/lib/resources/templates.js b/lib/resources/templates.js
index c06d19b..aaf0aab 100644
--- a/lib/resources/templates.js
+++ b/lib/resources/templates.js
@@ -86,7 +86,7 @@
// insert strings into the template directly
but have them parsed by the browser
// to detect HTML entities properly (e.g. a
in Firefox would show up as a
// space instead of an entity which would cause
an invalid HTML error)
- tempParams.push( $( '<div/>' ).html(
mw.html.escape( params[i] ) ).html() );
+ tempParams.push( $( '<div>' ).html(
mw.html.escape( params[i] ) ).html() );
} else if( params[i] instanceof jQuery ) {
// construct temporary placeholder nodes
// (using an actual invalid class name to not
interfere with any other node)
@@ -102,7 +102,7 @@
// Wrap template inside a html container to be able to easily
access all temporary nodes and
// insert any jQuery objects:
- $wrappedTemplate = $( '<html/>' ).html( template.plain() );
+ $wrappedTemplate = $( '<html>' ).html( template.plain() );
if( !areCachedParameterTypes( key, params ) ) {
if( !isValidHtml( template, $wrappedTemplate ) ) {
diff --git a/lib/resources/wikibase.Site.js b/lib/resources/wikibase.Site.js
index 74218b9..403f412 100644
--- a/lib/resources/wikibase.Site.js
+++ b/lib/resources/wikibase.Site.js
@@ -96,7 +96,7 @@
*/
getLinkTo: function( pageTitle ) {
var url = this.getUrlTo( pageTitle );
- return $( '<a/>', {
+ return $( '<a>', {
'href': url,
'text': pageTitle
} );
diff --git a/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
b/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
index 96f7cfe..72a6dca 100644
--- a/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
+++ b/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
@@ -66,7 +66,7 @@
if( text ) { // empty if entity without ID
$label[0].nodeValue += SPACE;
}
- var $undefinedInfo = $( '<span/>', {
+ var $undefinedInfo = $( '<span>', {
'class': 'wb-entity-undefinedinfo',
'dir': IS_RTL ? 'rtl' : 'ltr',
'text': mw.msg( 'parentheses', mw.msg(
'wikibase-label-empty' ) )
@@ -103,7 +103,7 @@
wb.utilities.ui.buildMissingEntityInfo = function( entityId, entityType
) {
entityType = typeof entityType === 'string' ? entityType :
entityType.TYPE;
- return $( '<span/>' ).text( entityId + SPACE ).append(
+ return $( '<span>' ).text( entityId + SPACE ).append(
$( '<span>', {
'class': 'wb-entity-undefinedinfo',
'dir': IS_RTL ? 'rtl' : 'ltr',
diff --git a/lib/tests/qunit/jquery.ui/jquery.ui.tagadata.tests.js
b/lib/tests/qunit/jquery.ui/jquery.ui.tagadata.tests.js
index db9f374..acc23e6 100644
--- a/lib/tests/qunit/jquery.ui/jquery.ui.tagadata.tests.js
+++ b/lib/tests/qunit/jquery.ui/jquery.ui.tagadata.tests.js
@@ -11,11 +11,11 @@
* @return {jQuery}
*/
function createTagadata( options ) {
- return $( '<ul/>' )
+ return $( '<ul>' )
.addClass( 'test_tagadata' )
- .append( $( '<li/>' ).text( 'A' ) )
- .append( $( '<li/>' ).text( 'B' ) )
- .append( $( '<li/>' ).text( 'C' ) )
+ .append( $( '<li>' ).text( 'A' ) )
+ .append( $( '<li>' ).text( 'B' ) )
+ .append( $( '<li>' ).text( 'C' ) )
.tagadata( options || {} )
.appendTo( 'body' );
}
@@ -112,7 +112,7 @@
tagadata.removeTag( tagadata.getTag( 'B' ) );
assert.strictEqual(
- tagadata.removeTag( $( '<span/>' ) ),
+ tagadata.removeTag( $( '<span>' ) ),
false,
'Trying to remove non-existent tag returns "false".'
);
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
index 0bbe4db..ab159a6 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
@@ -20,7 +20,7 @@
}
}, options || {} );
- var $aliasesview = $( '<div/>' )
+ var $aliasesview = $( '<div>' )
.addClass( 'test_aliasesview' )
.appendTo( 'body' )
.aliasesview( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.badgeselector.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.badgeselector.tests.js
index b02a3cc..361caf6 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.badgeselector.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.badgeselector.tests.js
@@ -65,7 +65,7 @@
languageCode: 'en'
}, options || {} );
- var $badgeselector = $( '<span/>' )
+ var $badgeselector = $( '<span>' )
.addClass( 'test_badgeselector' )
.appendTo( 'body' )
.badgeselector( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.tests.js
index 6459128..6e3721a 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.tests.js
@@ -19,7 +19,7 @@
throw new Error( 'Can only run this test on a HTML page
with "body" tag in the browser.' );
}
- return $( '<div/>' ).appendTo( $body );
+ return $( '<div>' ).appendTo( $body );
}
QUnit.module( 'jquery.wikibase.claimgrouplabelscroll', {
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
index e64246e..d9b0615 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
@@ -33,7 +33,7 @@
api: new wb.AbstractedRepoApi( new wb.RepoApi() )
};
- return $( '<div/>' )
+ return $( '<div>' )
.addClass( 'test_claimview' )
.claimview( options );
}
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
index dd1bfcb..b8bc554 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
@@ -21,7 +21,7 @@
}
}, options || {} );
- $node = $node || $( '<div/>' ).appendTo( 'body' );
+ $node = $node || $( '<div>' ).appendTo( 'body' );
var $descriptionview = $node
.addClass( 'test_descriptionview' )
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
index a6ca3b2..9b1fe8d 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
@@ -26,7 +26,7 @@
api: 'i am an api'
}, options || {} );
- return $( '<div/>' )
+ return $( '<div>' )
.appendTo( 'body' )
.addClass( 'test_fingerprintgroupview' )
.fingerprintgroupview( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
index 5a7cc2a..36ba66d 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
@@ -28,7 +28,7 @@
]
}, options || {} );
- return $( '<table/>' )
+ return $( '<table>' )
.appendTo( 'body' )
.addClass( 'test_fingerprintlistview' )
.fingerprintlistview( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
index 3e9d769..c0a78eb 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
@@ -23,7 +23,7 @@
}
}, options || {} );
- $node = $node || $( '<tbody/>' ).appendTo( $( '<table/>' ) );
+ $node = $node || $( '<tbody>' ).appendTo( $( '<table>' ) );
var $fingerprintview = $node
.addClass( 'test_fingerprintview' )
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
index d731969..e56b2b9 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
@@ -21,7 +21,7 @@
}
}, options || {} );
- $node = $node || $( '<div/>' ).appendTo( 'body' );
+ $node = $node || $( '<div>' ).appendTo( 'body' );
var $labelview = $node
.addClass( 'test_labelview' )
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
index 2887d5a..3df2904 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
@@ -13,7 +13,7 @@
* @return {jQuery}
*/
function createListview( value, options ) {
- var $node = $( '<div/>' ).addClass( 'test_listview' );
+ var $node = $( '<div>' ).addClass( 'test_listview' );
options = $.extend( {
listItemAdapter: new
$.wikibase.listview.ListItemAdapter( {
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
index 6c8ed81..a74a475 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
@@ -41,7 +41,7 @@
api: new wb.AbstractedRepoApi( new wb.RepoApi() )
} );
- return $( '<div/>' )
+ return $( '<div>' )
.addClass( 'test_referenceview' )
.referenceview( options );
}
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
index 77f5fe0..0f71130 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
@@ -17,7 +17,7 @@
entityStore: 'i am an entity store'
}, options );
- return $( '<div/>' )
+ return $( '<div>' )
.addClass( 'test_sitelinkgrouplistview')
.appendTo( $( 'body' ) )
.sitelinkgrouplistview( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
index 703bf62..4dffcb1 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
@@ -17,7 +17,7 @@
entityStore: new wb.store.EntityStore()
}, options );
- var $sitelinkgroupview = $( '<div/>' )
+ var $sitelinkgroupview = $( '<div>' )
.addClass( 'test_sitelinkgroupview')
.appendTo( $( 'body' ) )
.sitelinkgroupview( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
index a6495ea..8d7e53e 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
@@ -18,7 +18,7 @@
allowedSiteIds: ['aawiki', 'enwiki']
}, options );
- var $sitelinklistview = $( '<table/>' )
+ var $sitelinklistview = $( '<table>' )
.addClass( 'test_sitelinklistview')
.appendTo( $( 'body' ) )
.sitelinklistview( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
index 2dcad0a..2d2d1ab 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
@@ -16,7 +16,7 @@
allowedSiteIds: ['aawiki', 'enwiki']
}, options );
- return $( '<div/>' )
+ return $( '<div>' )
.addClass( 'test_sitelinkview' )
.appendTo( $( 'body' ) )
.sitelinkview( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
index b1c317b..10cd477 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
@@ -88,7 +88,7 @@
valueViewBuilder: valueViewBuilder
} );
- return $( '<div/>' )
+ return $( '<div>' )
.addClass( 'test_snaklistview' )
.snaklistview( options );
}
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
index ae4e06e..7a6e832 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
@@ -11,7 +11,7 @@
* @return {jQuery.wikibase.statementview.RankSelector}
*/
function createTestRankSelector( options ) {
- var $node = $( '<span/>' )
+ var $node = $( '<span>' )
.addClass( 'test_rankselector' )
.appendTo( 'body' );
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
index 8f4e016..5137389 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
@@ -12,7 +12,7 @@
* @return {jQuery}
*/
function createTestTooltip( options ) {
- var $node = $( '<span/>' )
+ var $node = $( '<span>' )
.addClass( 'test_tooltip' )
.appendTo( 'body' )
.wbtooltip( options );
diff --git
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.tests.js
index f63bd55..6141198 100644
---
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.addtoolbar.tests.js
@@ -25,7 +25,7 @@
* @return {jQuery}
*/
function createAddtoolbar( options ) {
- return $( '<span/>' )
+ return $( '<span>' )
.addClass( 'test_addtoolbar' )
.addtoolbar( options || {} );
}
diff --git
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.tests.js
index d23177b..e44d572 100644
---
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.edittoolbar.tests.js
@@ -47,10 +47,10 @@
* @return {jQuery}
*/
function createEdittoolbar( options ) {
- return $( '<span/>' )
+ return $( '<span>' )
.addClass( 'test_edittoolbar' )
.edittoolbar( $.extend( {
- interactionWidget: $( '<div/>'
).editablewidget().data( 'editablewidget' )
+ interactionWidget: $( '<div>'
).editablewidget().data( 'editablewidget' )
}, options || {} ) );
}
diff --git
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.tests.js
index 2ef11bb..9d72d3b 100644
---
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.movetoolbar.tests.js
@@ -46,7 +46,7 @@
* @return {jQuery}
*/
function createListview( value ) {
- var $listview = $( '<div/>' ).addClass( 'test_listview' );
+ var $listview = $( '<div>' ).addClass( 'test_listview' );
$listview.listview( {
listItemAdapter: new $.wikibase.listview.ListItemAdapter( {
diff --git
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.tests.js
index 0f4af5c..5f6aa67 100644
---
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.removetoolbar.tests.js
@@ -25,7 +25,7 @@
* @return {jQuery}
*/
function createRemovetoolbar( options ) {
- return $( '<span/>' )
+ return $( '<span>' )
.addClass( 'test_removetoolbar' )
.removetoolbar( options || {} );
}
diff --git
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbar.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbar.tests.js
index 477cce9..5b9abe6 100644
--- a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbar.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbar.tests.js
@@ -25,7 +25,7 @@
* @return {jQuery}
*/
function createTestToolbar( options ) {
- return $( '<span/>' )
+ return $( '<span>' )
.addClass( 'test_toolbar' )
.toolbar( options || {} );
}
@@ -48,8 +48,8 @@
} );
QUnit.test( 'Create & destroy toolbar with initial content', function( assert
) {
- var $container = $( '<span/>' ),
- $button = $( '<span/>' ).toolbarbutton( {
+ var $container = $( '<span>' ),
+ $button = $( '<span>' ).toolbarbutton( {
$label: 'label'
} ),
$toolbar = createTestToolbar( {
@@ -80,7 +80,7 @@
} );
QUnit.test( 'Create & destroy with renderItemSeparators=true', function(
assert ) {
- var $button = $( '<span/>' ).toolbarbutton( {
+ var $button = $( '<span>' ).toolbarbutton( {
$label: 'label'
} ),
$toolbar = createTestToolbar( {
@@ -106,7 +106,7 @@
QUnit.test( 'Set content dynamically via option()', function( assert ) {
var $toolbar = createTestToolbar(),
toolbar = $toolbar.data( 'toolbar' ),
- $button = $( '<span/>' ).toolbarbutton( {
+ $button = $( '<span>' ).toolbarbutton( {
$label: 'label'
} );
diff --git
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.tests.js
index ea423b2..f9f5362 100644
---
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbarbutton.tests.js
@@ -10,7 +10,7 @@
* @return {jQuery}
*/
var createTestButton = function( options ) {
- return $( '<span/>' )
+ return $( '<span>' )
.addClass( 'test_toolbarbutton' )
.toolbarbutton( options || {} );
};
diff --git
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbaritem.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbaritem.tests.js
index dc28a20..93edb5c 100644
---
a/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbaritem.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/toolbar/jquery.wikibase.toolbaritem.tests.js
@@ -10,7 +10,7 @@
* @return {jQuery}
*/
var createTestItem = function( options ) {
- return $( '<span/>' )
+ return $( '<span>' )
.text( 'text' )
.addClass( 'test_toolbaritem' )
.toolbaritem( options || {} );
diff --git a/lib/tests/qunit/jquery/jquery.removeClassByRegex.tests.js
b/lib/tests/qunit/jquery/jquery.removeClassByRegex.tests.js
index 4914748..4376e6001 100644
--- a/lib/tests/qunit/jquery/jquery.removeClassByRegex.tests.js
+++ b/lib/tests/qunit/jquery/jquery.removeClassByRegex.tests.js
@@ -9,7 +9,7 @@
QUnit.test( 'Basics', function( assert ) {
var classes = [ 'a11a', 'bbb', 'c333', 'dddd', 'e', '6', '7' ];
- var subject = $( '<div/>', {
+ var subject = $( '<div>', {
'class': classes.join( ' ' ) // should also work with more
than one space
} );
@@ -46,11 +46,11 @@
QUnit.test( 'Multiple elements', function( assert ) {
var subject = $(
- '<div/>', { 'class': 'A B C 1 2 3' }
+ '<div>', { 'class': 'A B C 1 2 3' }
).add(
- '<div/>', { 'class': 'AA BB CC 11 22 33' }
+ '<div>', { 'class': 'AA BB CC 11 22 33' }
).add(
- '<div/>', { 'class': 'AAA BBB CCC 111 222 333' }
+ '<div>', { 'class': 'AAA BBB CCC 111 222 333' }
);
assert.ok(
diff --git a/lib/tests/qunit/templates.tests.js
b/lib/tests/qunit/templates.tests.js
index cb9c7d5..fec2207 100644
--- a/lib/tests/qunit/templates.tests.js
+++ b/lib/tests/qunit/templates.tests.js
@@ -30,15 +30,15 @@
[ // single-parameter templates
'param',
'<div></div>',
- $( '<div/>').append( 'text' ),
- $( '<tr/>' ),
- $( '<td/>' ).append( $( '<span/>' ).text(
'text' ) ),
+ $( '<div>' ).append( 'text' ),
+ $( '<tr>' ),
+ $( '<td>' ).append( $( '<span>' ).text( 'text'
) ),
'text with spaces'
],
[ // two-parameter templates
[ 'param1', 'param2' ],
- [ 'param1', $( '<div/>' ) ],
- [ $( '<div/>' ), $( '<div/>').text( 'param2' ) ]
+ [ 'param1', $( '<div>' ) ],
+ [ $( '<div>' ), $( '<div>' ).text( 'param2' ) ]
]
];
@@ -201,12 +201,12 @@
if ( expected === '' ) {
assert.throws(
- function() { $( '<div/>' ).append(
mw.template( key, params ) ).html(); },
+ function() { $( '<div>' ).append(
mw.template( key, params ) ).html(); },
'Triggered error when trying to create
invalid HTML filling single param template "' + template + '" with "' +
paramMessage + '"'
);
} else {
assert.equal(
- replaceChevrons( $( '<div/>' ).append(
mw.template( key, params ) ).html() ),
+ replaceChevrons( $( '<div>' ).append(
mw.template( key, params ) ).html() ),
replaceChevrons( expected ),
'Verified template: "' + template + '"
with "' + paramMessage + '"'
);
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index 6ef2b4c..7ea43ab 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -246,7 +246,7 @@
return;
}
- var $hideMessage = $( '<a/>', {
+ var $hideMessage = $( '<a>', {
text: mw.msg( 'wikibase-copyrighttooltip-acknowledge' )
} ).appendTo( $message );
@@ -254,7 +254,7 @@
// we don't even have to add this new toolbar element to the
toolbar, we only use it
// to manage the tooltip which will have the 'save' button as
element to point to.
// The 'save' button can still have its own tooltip though.
- var $messageAnchor = $( '<span/>' )
+ var $messageAnchor = $( '<span>' )
.appendTo( 'body' )
.toolbaritem()
.wbtooltip( {
diff --git a/repo/resources/wikibase.ui.entitysearch.js
b/repo/resources/wikibase.ui.entitysearch.js
index 572be51..dadfacb 100644
--- a/repo/resources/wikibase.ui.entitysearch.js
+++ b/repo/resources/wikibase.ui.entitysearch.js
@@ -56,7 +56,7 @@
$( function() {
var $form = $( '#searchform ' ),
$input = $( '#searchInput' ),
- $hiddenInput = $( '<input type="hidden"
name="search"/>' );
+ $hiddenInput = $( '<input type="hidden" name="search"
/>' );
/**
* Updates the suggestion list special item that triggers a
full-text search.
@@ -87,7 +87,7 @@
.addClass( 'special-query' )
);
- var $searchMenu = $( '<ul/>' ).ooMenu( {
+ var $searchMenu = $( '<ul>' ).ooMenu( {
customItems: [
new $.ui.ooMenu.CustomItem( $searchContaining,
null, function() {
$form.submit();
--
To view, visit https://gerrit.wikimedia.org/r/167175
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bec09777289beb2bd9c05315fb26b19f09009a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
