jenkins-bot has submitted this change and it was merged.

Change subject: [FIX] Site tests: Actually execute test
......................................................................


[FIX] Site tests: Actually execute test

The tests were hidden and never executed. Introduced with
I1655f6c9e6894fc053af9ee33b255287bbeb6b28.

Change-Id: I11fd255da6eb4fc7816d99b8408e331d9b8fe618
---
M tests/site_tests.py
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  John Vandenberg: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/site_tests.py b/tests/site_tests.py
index 90d4f9f..9765017 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -96,12 +96,10 @@
 
     cached = True
 
-    def testProperties(self):
+    def test_properties(self, key):
         """Test cases for BaseSite properties."""
-        # Test doc_subpage property.
-        def test_properties(self, key):
-            mysite = self.get_site(key)
-            self.assertEqual(mysite.doc_subpage, self.sites[key]['result'])
+        mysite = self.get_site(key)
+        self.assertEqual(mysite.doc_subpage, self.sites[key]['result'])
 
 
 class TestSiteObject(DefaultSiteTestCase):

-- 
To view, visit https://gerrit.wikimedia.org/r/167196
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11fd255da6eb4fc7816d99b8408e331d9b8fe618
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <commodorefabia...@gmx.de>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhall...@arctus.nl>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to