jenkins-bot has submitted this change and it was merged.
Change subject: FlaggedElement: Fix PHP notice
......................................................................
FlaggedElement: Fix PHP notice
Change-Id: Ic61a698982030c7a1a9bc6bb3f7fd1a8ad2674db
---
M php/elements/OoUiFlaggedElement.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/php/elements/OoUiFlaggedElement.php
b/php/elements/OoUiFlaggedElement.php
index 5214238..f2c4203 100644
--- a/php/elements/OoUiFlaggedElement.php
+++ b/php/elements/OoUiFlaggedElement.php
@@ -15,7 +15,7 @@
*
* @param OoUiElement $element Element being mixed into
* @param array $config Configuration options
- * @param string $config['flags'] Flags
+ * @param string|string[] $config['flags'] Flags
*/
public function __construct( OoUiElement $element, array $config =
array() ) {
// Parent constructor
@@ -78,7 +78,7 @@
if ( is_string( $flags ) ) {
// Set
- if ( !$this->flags[$flags] ) {
+ if ( !isset( $this->flags[$flags] ) ) {
$this->flags[$flags] = true;
$add[] = $classPrefix . $flags;
}
--
To view, visit https://gerrit.wikimedia.org/r/167312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic61a698982030c7a1a9bc6bb3f7fd1a8ad2674db
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
