jenkins-bot has submitted this change and it was merged.
Change subject: Update VE core submodule to master (f8a563a)
......................................................................
Update VE core submodule to master (f8a563a)
New changes:
e251898 [BREAKING CHANGE] Allow tools to specify which selection types they
support
Local changes:
New requiresSelection api for tools
Change-Id: Idc3f62d60bfb5710f786734c342f71b1c73fd4c0
---
M lib/ve
M modules/ve-mw/ui/tools/ve.ui.MWCitationDialogTool.js
M modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
M modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
M modules/ve-mw/ui/tools/ve.ui.MWTransclusionDialogTool.js
5 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/ve b/lib/ve
index 51a919d..f8a563a 160000
--- a/lib/ve
+++ b/lib/ve
-Subproject commit 51a919d4d99082a696037579b4ef70fd7e772ef5
+Subproject commit f8a563a64ecb7a471d01a3d917f97e003216e304
diff --git a/modules/ve-mw/ui/tools/ve.ui.MWCitationDialogTool.js
b/modules/ve-mw/ui/tools/ve.ui.MWCitationDialogTool.js
index e9ede3a..40219a9 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWCitationDialogTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWCitationDialogTool.js
@@ -30,7 +30,7 @@
ve.ui.MWCitationDialogTool.static.modelClasses = [ ve.dm.MWReferenceNode ];
-ve.ui.MWCitationDialogTool.static.requiresRange = true;
+ve.ui.MWCitationDialogTool.static.requiresSelection = [ 'linear' ];
/**
* Only display tool for single-template transclusions of these templates.
diff --git a/modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
b/modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
index 9509cdc..5d69dcb 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
@@ -25,7 +25,7 @@
OO.ui.deferMsg( 'visualeditor-dialogbutton-media-tooltip' );
ve.ui.MWMediaDialogTool.static.modelClasses = [ ve.dm.MWBlockImageNode,
ve.dm.MWInlineImageNode ];
ve.ui.MWMediaDialogTool.static.commandName = 'media';
-ve.ui.MWMediaDialogTool.static.requiresRange = true;
+ve.ui.MWMediaDialogTool.static.requiresSelection = [ 'linear' ];
ve.ui.MWMediaDialogTool.static.autoAddToCatchall = false;
ve.ui.MWMediaDialogTool.static.autoAddToGroup = false;
ve.ui.toolFactory.register( ve.ui.MWMediaDialogTool );
diff --git a/modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
b/modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
index d3eef69..2397a4b 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
@@ -25,7 +25,7 @@
OO.ui.deferMsg( 'visualeditor-dialogbutton-reference-tooltip' );
ve.ui.MWReferenceDialogTool.static.modelClasses = [ ve.dm.MWReferenceNode ];
ve.ui.MWReferenceDialogTool.static.commandName = 'reference';
-ve.ui.MWReferenceDialogTool.static.requiresRange = true;
+ve.ui.MWReferenceDialogTool.static.requiresSelection = [ 'linear' ];
ve.ui.toolFactory.register( ve.ui.MWReferenceDialogTool );
/**
@@ -48,7 +48,7 @@
OO.ui.deferMsg( 'visualeditor-dialog-reference-useexisting-tool' );
ve.ui.MWUseExistingReferenceDialogTool.static.modelClasses = [];
ve.ui.MWUseExistingReferenceDialogTool.static.commandName =
'reference/existing';
-ve.ui.MWUseExistingReferenceDialogTool.static.requiresRange = true;
+ve.ui.MWUseExistingReferenceDialogTool.static.requiresSelection = [ 'linear' ];
ve.ui.MWUseExistingReferenceDialogTool.static.autoAddToGroup = false;
ve.ui.MWUseExistingReferenceDialogTool.static.autoAddToCatchall = false;
@@ -94,5 +94,5 @@
OO.ui.deferMsg( 'visualeditor-dialogbutton-referenceslist-tooltip' );
ve.ui.MWReferencesListDialogTool.static.modelClasses = [
ve.dm.MWReferencesListNode ];
ve.ui.MWReferencesListDialogTool.static.commandName = 'referencesList';
-ve.ui.MWReferencesListDialogTool.static.requiresRange = true;
+ve.ui.MWReferencesListDialogTool.static.requiresSelection = [ 'linear' ];
ve.ui.toolFactory.register( ve.ui.MWReferencesListDialogTool );
diff --git a/modules/ve-mw/ui/tools/ve.ui.MWTransclusionDialogTool.js
b/modules/ve-mw/ui/tools/ve.ui.MWTransclusionDialogTool.js
index 0eb7d15..cb7840d 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWTransclusionDialogTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWTransclusionDialogTool.js
@@ -35,7 +35,7 @@
ve.ui.MWTransclusionDialogTool.static.modelClasses = [
ve.dm.MWTransclusionNode ];
-ve.ui.MWTransclusionDialogTool.static.requiresRange = true;
+ve.ui.MWTransclusionDialogTool.static.requiresSelection = [ 'linear' ];
ve.ui.MWTransclusionDialogTool.static.commandName = 'transclusion';
--
To view, visit https://gerrit.wikimedia.org/r/166776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc3f62d60bfb5710f786734c342f71b1c73fd4c0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
