jenkins-bot has submitted this change and it was merged.
Change subject: Make sure, loading circle is really visible
......................................................................
Make sure, loading circle is really visible
Don't delete topics after the api request finished, do it before.
Change-Id: Ia85ab3564836c40e2c9030e8cf097cc15cc2dca6
---
M javascripts/modules/talk/TalkOverlay.js
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/talk/TalkOverlay.js
b/javascripts/modules/talk/TalkOverlay.js
index bda6ef0..251aed8 100644
--- a/javascripts/modules/talk/TalkOverlay.js
+++ b/javascripts/modules/talk/TalkOverlay.js
@@ -65,6 +65,9 @@
// show a spinner
this.showSpinner();
+ // clear actual content, if any
+ this.$( '.page-list' ).empty();
+
// FIXME: use Page's mechanisms for retrieving
page data instead
M.pageApi.getPage( options.title ).fail(
function( resp ) {
// If the API returns the error code
'missingtitle', that means the
@@ -93,8 +96,6 @@
// FIXME: just for tests
this.page = page;
- // clear actual content, if any
- this.$( '.page-list' ).empty();
sections = page.getSubSections();
// Add content header explanation
--
To view, visit https://gerrit.wikimedia.org/r/167377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia85ab3564836c40e2c9030e8cf097cc15cc2dca6
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de>
Gerrit-Reviewer: Awjrichards <aricha...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
