jenkins-bot has submitted this change and it was merged.

Change subject: Let help link target be locally over-ridden; default to the MW 
help page
......................................................................


Let help link target be locally over-ridden; default to the MW help page

Bug: 67621
Change-Id: Ic205a8bd51516d3fa580955b310014e4fe30ec6d
---
M TemplateData.php
M i18n/en.json
M i18n/qqq.json
M modules/ext.templateDataGenerator.core.js
4 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Mooeypoo: Looks good to me, approved
  Siebrand: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/TemplateData.php b/TemplateData.php
index 20e8831..ee1a81c 100644
--- a/TemplateData.php
+++ b/TemplateData.php
@@ -67,6 +67,7 @@
        'messages' => array(
                'templatedata-editbutton',
                'templatedata-helplink',
+               'templatedata-helplink-target',
                'templatedata-errormsg-jsonbadformat',
        )
 );
diff --git a/i18n/en.json b/i18n/en.json
index 0e0d529..905db1e 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -24,6 +24,7 @@
        "templatedata-editbutton": "Manage TemplateData",
        "templatedata-errormsg-jsonbadformat": "Bad JSON format. Either correct 
it, or delete the current <templatedata> tags and try again.",
        "templatedata-helplink": "Information about TemplateData",
+       "templatedata-helplink-target": 
"//www.mediawiki.org/wiki/Special:MyLanguage/Help:TemplateData",
        "templatedata-invalid-duplicate-value": "Property \"$1\" (\"$3\") is a 
duplicate of \"$2\".",
        "templatedata-invalid-empty-array": "Property \"$1\" must have at least 
one value in its array.",
        "templatedata-invalid-length": "Data too large to save 
({{formatnum:$1}} {{PLURAL:$1|byte|bytes}}, {{PLURAL:$2|limit is}} 
{{formatnum:$2}})",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 0585b0d..4a4afe4 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -30,6 +30,7 @@
        "templatedata-editbutton": "The label of the button to manage 
templatedata, appearing above the editor field.",
        "templatedata-errormsg-jsonbadformat": "Error message that appears in 
case the JSON string is not possible to parse. The user is asked to either 
correct the json syntax or delete the values between the &lt;templatedata&gt; 
tags and try again.",
        "templatedata-helplink": "The label of the link to the TemplateData 
documentation, appearing above the editor field.",
+       "templatedata-helplink-target": "{{Optional}} The target of the link to 
the TemplateData documentation",
        "templatedata-invalid-duplicate-value": "Displayed when an array that 
must only contain unique values contains a duplicate.\n* $1 - name of property 
containing the duplicate\n* $2 - name of property with first occurrence of 
value\n* $3 - the value being duplicated",
        "templatedata-invalid-empty-array": "Error message when a property that 
must be non-empty is empty. Parameters:\n* $1 - property name (\"paramOrder\" 
or \"sets.{$setNr}.params\")",
        "templatedata-invalid-length": "Error message when generated JSON's 
length exceed database limits.\n* $1 - length of generated JSON\n* $2 - maximal 
allowed length",
diff --git a/modules/ext.templateDataGenerator.core.js 
b/modules/ext.templateDataGenerator.core.js
index 9b7526c..606f484 100644
--- a/modules/ext.templateDataGenerator.core.js
+++ b/modules/ext.templateDataGenerator.core.js
@@ -1390,7 +1390,7 @@
                                                $helpLink: $( '<a>' )
                                                        .addClass( 
'tdg-editscreen-main-helplink' )
                                                        .text( mw.msg( 
'templatedata-helplink' ) )
-                                                       .attr( 'href', 
'https://www.mediawiki.org/wiki/Extension:TemplateData' )
+                                                       .attr( 'href', mw.msg( 
'templatedata-helplink-target' ) )
                                                        .attr( 'target', 
'_blank' ),
                                                /**
                                                 * Define the error box for the 
main template edit

-- 
To view, visit https://gerrit.wikimedia.org/r/163029
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic205a8bd51516d3fa580955b310014e4fe30ec6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateData
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to