jenkins-bot has submitted this change and it was merged.
Change subject: Fix regression and use the svg version in beta for issues icon
......................................................................
Fix regression and use the svg version in beta for issues icon
Bug: 67423
Bug: 72320
Change-Id: Icb6673af127b29cdb9705ae979b13fc7d373a4d7
---
M javascripts/modules/issues/issues.js
D less/modules/images/issues/blue.png
M less/modules/issues.less
3 files changed, 5 insertions(+), 11 deletions(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/issues/issues.js
b/javascripts/modules/issues/issues.js
index 95c0b8e..62d34a4 100644
--- a/javascripts/modules/issues/issues.js
+++ b/javascripts/modules/issues/issues.js
@@ -52,14 +52,16 @@
}
} );
- $link = new Icon( { tagName: 'a', name: 'cleanup', hasText:
true } ).
+ $link = new Icon( { tagName: 'a', name: 'cleanup', hasText:
true,
+ label: labelText,
+ additionalClassNames: 'mw-mf-cleanup' } ).
$el.children().eq( 0 ).attr( 'href', '#/issues' );
M.overlayManager.add( /^\/issues$/, function() {
return new CleanupOverlay( { issues: issues,
headingText: headingText } );
} );
- $link.text( labelText ).insertBefore( $metadata.eq( 0 ) );
+ $link.insertBefore( $metadata.eq( 0 ) );
$metadata.remove();
}
diff --git a/less/modules/images/issues/blue.png
b/less/modules/images/issues/blue.png
deleted file mode 100644
index 0d9b1b3..0000000
--- a/less/modules/images/issues/blue.png
+++ /dev/null
Binary files differ
diff --git a/less/modules/issues.less b/less/modules/issues.less
index 32b055f..af6fe11 100644
--- a/less/modules/issues.less
+++ b/less/modules/issues.less
@@ -8,17 +8,9 @@
.mw-mf-cleanup {
display: inline-block;
padding: 10px 15px 10px (@smallIconSize + 20px);
- .background-image('images/issues/blue.png');
+ .background-image-svg-quick( 'images/issues/blue-triangle' );
margin-bottom: 4px;
background-position: 10px center;
-}
-
-.app,
-.alpha,
-.beta {
- .mw-mf-cleanup {
- .background-image-svg( 'images/issues/blue-triangle.svg',
'images/issues/blue-triangle.png' );
- }
}
// overlay styles
--
To view, visit https://gerrit.wikimedia.org/r/167634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb6673af127b29cdb9705ae979b13fc7d373a4d7
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
