Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168822
Change subject: Fix missing edit preview
......................................................................
Fix missing edit preview
Add a "new line" to section.hogan, too.
Bug: 72522
Change-Id: I16edec975a16a87f1f426d84dd126ac8aa83d90e
---
M javascripts/modules/editor/EditorOverlay.js
M templates/section.hogan
2 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/22/168822/1
diff --git a/javascripts/modules/editor/EditorOverlay.js
b/javascripts/modules/editor/EditorOverlay.js
index 03eb8b1..dc08ed2 100644
--- a/javascripts/modules/editor/EditorOverlay.js
+++ b/javascripts/modules/editor/EditorOverlay.js
@@ -5,7 +5,6 @@
$.inArray( mw.config.get( 'wgNamespaceNumber' ),
mw.config.get( 'wgVisualEditorConfig' ).namespaces ) > -1 &&
mw.config.get( 'wgTranslatePageTranslation' ) !==
'translation' &&
mw.config.get( 'wgPageContentModel' ) === 'wikitext',
- Section = M.require( 'Section' ),
EditorApi = M.require( 'modules/editor/EditorApi' ),
AbuseFilterPanel = M.require( 'modules/editor/AbuseFilterPanel'
),
EditorOverlay;
@@ -140,11 +139,9 @@
this.api.getPreview( params ).done( function (
parsedText, parsedSectionLine ) {
// On desktop edit summaries strip tags. Mimic
this behavior on mobile devices
self.sectionLine = $( '<div/>' ).html(
parsedSectionLine ).text();
- new Section( {
- el: self.$preview,
- content: parsedText
// bug 49218: stop links from being clickable
(note user can still hold down to navigate to them)
- } ).$( 'a' ).on( 'click', false );
+ self.$preview.html( parsedText ).find( 'a'
).on( 'click', false );
+
// Emit event so we can perform enhancements to
page
M.emit( 'edit-preview', self );
} ).fail( function () {
diff --git a/templates/section.hogan b/templates/section.hogan
index e9c0ea0..75af10f 100644
--- a/templates/section.hogan
+++ b/templates/section.hogan
@@ -1 +1 @@
-<h{{level}} id="{{anchor}}">{{{line}}}</h{{level}}>{{{text}}}
\ No newline at end of file
+<h{{level}} id="{{anchor}}">{{{line}}}</h{{level}}>{{{text}}}
--
To view, visit https://gerrit.wikimedia.org/r/168822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16edec975a16a87f1f426d84dd126ac8aa83d90e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
