John Vandenberg has submitted this change and it was merged.
Change subject: Fix page_tests testBasePageConstructor
......................................................................
Fix page_tests testBasePageConstructor
Empty string titles for BasePage raise InvalidTitle during Link.parse
Change-Id: I6d4fb9ff02d472f2e71933084de71a7bc355c154
---
M tests/page_tests.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Nullzero: Verified; Looks good to me, approved
diff --git a/tests/page_tests.py b/tests/page_tests.py
index ab229ea..54355cf 100644
--- a/tests/page_tests.py
+++ b/tests/page_tests.py
@@ -10,6 +10,7 @@
import sys
import pywikibot
from pywikibot import config
+from pywikibot import InvalidTitle
import pywikibot.page
from tests.aspects import unittest, TestCase, DefaultSiteTestCase
@@ -279,9 +280,9 @@
# the site parameter, with the title parameter defaulted to
# empty string
page = pywikibot.page.BasePage(site)
- self.assertEqual(page.title(), u'')
+ self.assertRaises(InvalidTitle, page.title)
page = pywikibot.page.BasePage(site, title=u'')
- self.assertEqual(page.title(), u'')
+ self.assertRaises(InvalidTitle, page.title)
self.assertRaises(ValueError, pywikibot.page.BasePage, site,
title=None)
def testPageConstructor(self):
--
To view, visit https://gerrit.wikimedia.org/r/168911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d4fb9ff02d472f2e71933084de71a7bc355c154
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhall...@arctus.nl>
Gerrit-Reviewer: Nullzero <nullzero.f...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
