[MediaWiki-commits] [Gerrit] Fix GlobalRenameRequest::setNewName() checking the wrong value - change (mediawiki...CentralAuth)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/168928

Change subject: Fix GlobalRenameRequest::setNewName() checking the wrong value
......................................................................

Fix GlobalRenameRequest::setNewName() checking the wrong value

Spotted in CR by Krenair

Change-Id: Ibbbefed83b2d15b52d94151631ba742a942da9d9
---
M includes/GlobalRename/GlobalRenameRequest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/28/168928/1

diff --git a/includes/GlobalRename/GlobalRenameRequest.php 
b/includes/GlobalRename/GlobalRenameRequest.php
index b839a4c..c18ee05 100644
--- a/includes/GlobalRename/GlobalRenameRequest.php
+++ b/includes/GlobalRename/GlobalRenameRequest.php
@@ -145,7 +145,7 @@
         */
        public function setNewName( $newName ) {
                $newName = User::getCanonicalName( $newName, 'creatable' );
-               if ( $this->newName === false ) {
+               if ( $newName === false ) {
                        throw new MWException( "Invalid username '{$newName}'" 
);
                }
                $this->newName = $newName;

-- 
To view, visit https://gerrit.wikimedia.org/r/168928
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbbefed83b2d15b52d94151631ba742a942da9d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits