Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169218
Change subject: Turn FieldLayout into a <label/>
......................................................................
Turn FieldLayout into a <label/>
This will magically make clicking on labels work without JavaScript,
and hopefully has no bad side-effects. Hopefully.
Change-Id: I95eabef744d661d0f8036ca6a044f5b8bd913739
---
M php/layouts/OoUiFieldLayout.php
M src/layouts/FieldLayout.js
2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/18/169218/1
diff --git a/php/layouts/OoUiFieldLayout.php b/php/layouts/OoUiFieldLayout.php
index ce48de6..8c644bd 100644
--- a/php/layouts/OoUiFieldLayout.php
+++ b/php/layouts/OoUiFieldLayout.php
@@ -14,6 +14,11 @@
* checkboxes or radio buttons
*/
class OoUiFieldLayout extends OoUiLayout {
+
+ /* Static properties */
+
+ public static $tagName = 'label';
+
/**
* Alignment.
*
diff --git a/src/layouts/FieldLayout.js b/src/layouts/FieldLayout.js
index 2b669d8..e7a3c45 100644
--- a/src/layouts/FieldLayout.js
+++ b/src/layouts/FieldLayout.js
@@ -73,6 +73,10 @@
OO.inheritClass( OO.ui.FieldLayout, OO.ui.Layout );
OO.mixinClass( OO.ui.FieldLayout, OO.ui.LabelElement );
+/* Static Properties */
+
+OO.ui.FieldLayout.static.tagName = 'label';
+
/* Methods */
/**
--
To view, visit https://gerrit.wikimedia.org/r/169218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95eabef744d661d0f8036ca6a044f5b8bd913739
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
