jenkins-bot has submitted this change and it was merged.
Change subject: Choose correct side for positioning
......................................................................
Choose correct side for positioning
Bug: 72647
Change-Id: I9a9c62643af6dd29afdc1e195e6496e86c4ae048
---
M lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
index a3dc679..ae19b6d 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js
@@ -243,11 +243,12 @@
* @param {jQuery} $within
*/
function positionElementInOneLineWithAnother( $element, $target,
$within ) {
+ var side = $( 'html' ).prop( 'dir' ) === 'ltr' ? 'left' :
'right';
$element
.stop( ANIMATION_QUEUE, true, false ) // stop all queued
animations, don't jump to end
.position( {
- my: 'left top',
- at: 'left top',
+ my: side + ' top',
+ at: side + ' top',
of: $target,
within: $within,
using: function( css, calc ) {
--
To view, visit https://gerrit.wikimedia.org/r/169609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a9c62643af6dd29afdc1e195e6496e86c4ae048
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ebrahim <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
