Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169624
Change subject: Convert string to integer
......................................................................
Convert string to integer
toFixed returns a string when the schema says it should be a number.
Bug: 72639
Change-Id: I1564502e14b2d2bc307e6e6052e74c2cd5ccc59c
---
M javascripts/modules/wikigrok/WikiGrokDialog.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/24/169624/1
diff --git a/javascripts/modules/wikigrok/WikiGrokDialog.js
b/javascripts/modules/wikigrok/WikiGrokDialog.js
index af4c71c..ef4678b 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialog.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialog.js
@@ -64,9 +64,9 @@
taskToken: this.defaults.taskToken,
userToken: this.options.userToken,
// the position of the top of the widget in
viewports (as a unit)
- widgetOffset: ( this.$el.offset().top /
$window.height() ).toFixed( 2 ),
+ widgetOffset: parseFloat( (
this.$el.offset().top / $window.height() ).toFixed( 2 ) ),
// top of the document - top of the viewport in
viewports (as a unit)
- scrollOffset: ( $window.scrollTop() /
$window.height() ).toFixed( 2 )
+ scrollOffset: parseFloat( ( $window.scrollTop()
/ $window.height() ).toFixed( 2 ) )
};
if ( this.options.testing ) {
data.testing = true;
--
To view, visit https://gerrit.wikimedia.org/r/169624
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1564502e14b2d2bc307e6e6052e74c2cd5ccc59c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
