Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169638

Change subject: MWTransclusionModel: Exclude parts serialising to '' from the 
plain object
......................................................................

MWTransclusionModel: Exclude parts serialising to '' from the plain object

So we get rid of empty content nodes

Bug: 63341
Change-Id: I1d49cc709bf92cc53ba064d148a76650c5143935
---
M modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/38/169638/1

diff --git a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js 
b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
index 42ec7f1..515014f 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
@@ -312,7 +312,7 @@
                for ( i = 0, len = this.parts.length; i < len; i++ ) {
                        part = this.parts[i];
                        serialization = part.serialize();
-                       if ( serialization !== undefined ) {
+                       if ( serialization !== undefined && serialization !== 
'' ) {
                                obj.parts.push( serialization );
                        }
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/169638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d49cc709bf92cc53ba064d148a76650c5143935
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to