Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169644
Change subject: Remove more references to ve.bind
......................................................................
Remove more references to ve.bind
Seems some of them have crept back in since I1a7fc7f2 (and we missed one
somehow)
Bug: 72156
Change-Id: I5631fb7d5963d06aeb238c1daa44344b2060ef1a
---
M modules/ve-mw/dm/models/ve.dm.MWImageModel.js
M modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
M modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
5 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/44/169644/1
diff --git a/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
b/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
index b0cd7b2..7f350b8 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
@@ -274,7 +274,7 @@
// Call for updated scalable
if ( remoteFilename ) {
- ve.dm.MWImageNode.static.getScalablePromise( remoteFilename
).done( ve.bind( function ( info ) {
+ ve.dm.MWImageNode.static.getScalablePromise( remoteFilename
).done( function ( info ) {
this.scalable.setOriginalDimensions( {
width: info.width,
height: info.height
@@ -287,7 +287,7 @@
info.mediatype,
this.scalable
);
- }, this ) );
+ }.bind( this ) );
}
// Resize the new image's current dimensions to default or based on the
bounding box
@@ -1049,7 +1049,7 @@
// Call for updated scalable
if ( imageName ) {
- ve.dm.MWImageNode.static.getScalablePromise( imageName ).done(
ve.bind( function ( info ) {
+ ve.dm.MWImageNode.static.getScalablePromise( imageName ).done(
function ( info ) {
this.scalable.setOriginalDimensions( {
width: info.width,
height: info.height
@@ -1070,7 +1070,7 @@
this.initialHash.scalable.currentDimensions =
this.scalable.getDefaultDimensions();
}
- }, this ) );
+ }.bind( this ) );
}
};
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
index 42ec7f1..2038144 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
@@ -237,8 +237,8 @@
lang: mw.config.get( 'wgUserLanguage' ),
redirects: '1'
} )
- .done( ve.bind( this.fetchRequestDone, this, titles,
specs ) )
- .always( ve.bind( this.fetchRequestAlways, this, queue
) );
+ .done( this.fetchRequestDone.bind( this, titles, specs
) )
+ .always( this.fetchRequestAlways.bind( this, queue ) );
};
ve.dm.MWTransclusionModel.prototype.fetchRequestDone = function (
titles, specs, data ) {
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
index 2d8e3cb..3054c37 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js
@@ -273,7 +273,7 @@
ve.dm.MWImageNode.prototype.getScalable = function () {
if ( !this.scalablePromise ) {
this.scalablePromise =
ve.dm.MWImageNode.static.getScalablePromise( this.getFilename() )
- .done( ve.bind( function ( info ) {
+ .done( function ( info ) {
if ( info ) {
this.getScalable().setOriginalDimensions( {
width: info.width,
@@ -288,7 +288,7 @@
this.getScalable()
);
}
- }, this ) );
+ }.bind( this ) );
}
// Parent method
return ve.dm.ResizableNode.prototype.getScalable.call( this );
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index ca10ef4..b7f3c47 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -1205,9 +1205,9 @@
{ dir: this.surface.getModel().getDocument().getLang() }
)
// Call onSaveDialogClose() when the save dialog starts
closing
- .always( ve.bind( function ( opened ) {
- opened.always( ve.bind( this.onSaveDialogClose,
this ) );
- }, this ) );
+ .always( function ( opened ) {
+ opened.always( this.onSaveDialogClose.bind(
this ) );
+ }.bind( this ) );
this.emit( 'saveWorkflowBegin' );
}.bind( this ) );
};
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
index a7e52f3..527f700 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
@@ -447,7 +447,7 @@
this.transclusionModel,
data.template
);
promise =
this.transclusionModel.addPart( template ).done(
- ve.bind(
this.initializeNewTemplateParameters, this )
+
this.initializeNewTemplateParameters.bind( this )
);
} else {
// New template placeholder
@@ -460,7 +460,7 @@
// Load existing template
promise = this.transclusionModel
.load( ve.copy(
this.selectedNode.getAttribute( 'mw' ) ) )
- .done( ve.bind(
this.initializeTemplateParameters, this ) );
+ .done(
this.initializeTemplateParameters.bind( this ) );
}
this.actions.setAbilities( { apply: false, insert:
false } );
this.pushPending();
--
To view, visit https://gerrit.wikimedia.org/r/169644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5631fb7d5963d06aeb238c1daa44344b2060ef1a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
