jenkins-bot has submitted this change and it was merged.
Change subject: Fix off-by-one error in mw.track subscriber
......................................................................
Fix off-by-one error in mw.track subscriber
For mw.track( 'event.foo' ), it would try to load
'schema..foo'.
Also listen for 'event.' instead of 'event', in case
someone decides to use 'events.' or 'eventually.'
or whatever.
Bug: 72197
Change-Id: Idb7db8dfa12d24955ea8d51d7280f9438f8b87a7
---
M modules/ext.eventLogging.subscriber.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.eventLogging.subscriber.js
b/modules/ext.eventLogging.subscriber.js
index b78bc1a..6c812fa 100644
--- a/modules/ext.eventLogging.subscriber.js
+++ b/modules/ext.eventLogging.subscriber.js
@@ -31,7 +31,7 @@
* @param {Object} event
*/
function handleTrackedEvent( topic, event ) {
- var schema = titleCase( topic.slice( topic.indexOf( '.' ) ) ),
+ var schema = titleCase( topic.slice( topic.indexOf( '.' ) + 1 )
),
dependencies = [ 'ext.eventLogging', 'schema.' + schema
];
mediaWiki.loader.using( dependencies, function () {
@@ -40,7 +40,7 @@
}
$( window ).on( 'load', function () {
- mw.trackSubscribe( 'event', handleTrackedEvent );
+ mw.trackSubscribe( 'event.', handleTrackedEvent );
} );
} ( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/167326
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb7db8dfa12d24955ea8d51d7280f9438f8b87a7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
