jenkins-bot has submitted this change and it was merged.
Change subject: Remove initStorer callback
......................................................................
Remove initStorer callback
This is no longer needed since none of the browsers we serve JavaScript
to require userData. IE 8 and up (the lowest IE that gets JavaScript)
support localStorage.
The callback parameter is optional and initStorer already returns
the storage object.
Change-Id: Id55f2ea78576c85d348896c4ee13331f140c3eb4
---
M modules/engine/components/common/flow-component-engines.js
1 file changed, 2 insertions(+), 9 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
EBernhardson: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/engine/components/common/flow-component-engines.js
b/modules/engine/components/common/flow-component-engines.js
index b4c62ee..97ce7d1 100644
--- a/modules/engine/components/common/flow-component-engines.js
+++ b/modules/engine/components/common/flow-component-engines.js
@@ -14,14 +14,7 @@
* Contains Storer.js's (fallback) storage engines.
* @type {{ cookieStorage: Storer.cookieStorage, memoryStorage:
Storer.memoryStorage, sessionStorage: Storer.sessionStorage, localStorage:
Storer.localStorage }}
*/
- mw.flow.StorageEngine = FlowComponentEnginesMixin.static.StorageEngine
= {};
- mw.flow.StorageEngine = FlowComponentEnginesMixin.static.StorageEngine
= initStorer( function ( Storer ) {
- // Callback (for older IE browsers; sets userData in place of
localStorage on DOMReady)
- mw.flow.StorageEngine.cookieStorage =
FlowComponentEnginesMixin.static.StorageEngine.cookieStorage =
Storer.cookieStorage;
- mw.flow.StorageEngine.memoryStorage =
FlowComponentEnginesMixin.static.StorageEngine.memoryStorage =
Storer.memoryStorage;
- mw.flow.StorageEngine.sessionStorage =
FlowComponentEnginesMixin.static.StorageEngine.sessionStorage =
Storer.sessionStorage;
- mw.flow.StorageEngine.localStorage =
FlowComponentEnginesMixin.static.StorageEngine.localStorage =
Storer.localStorage;
- }, { 'prefix': '_WMFLOW_' } );
+ mw.flow.StorageEngine = FlowComponentEnginesMixin.static.StorageEngine
= initStorer( { 'prefix': '_WMFLOW_' } );
/**
* Contains the Flow templating engine translation class (in case we
change templating engines).
@@ -37,4 +30,4 @@
// Copy static and prototype from mixin to main class
mw.flow.mixinComponent( 'component', FlowComponentEnginesMixin );
-}( jQuery, mediaWiki, mediaWiki.flow.vendor.initStorer ) );
\ No newline at end of file
+}( jQuery, mediaWiki, mediaWiki.flow.vendor.initStorer ) );
--
To view, visit https://gerrit.wikimedia.org/r/168100
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id55f2ea78576c85d348896c4ee13331f140c3eb4
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
