QChris has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170160
Change subject: For ganglia views, use description as name only if it is set
......................................................................
For ganglia views, use description as name only if it is set
The view's description got only used when it evaluated to false. This
made kafka views (and some other disappear).
Hence, we now use the description only as view name, if it is set. And
fallback to the name, if it the description unset.
Change-Id: I9e8ded3abd71ee462e29893455678859410eb216
---
M manifests/ganglia.pp
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/60/170160/1
diff --git a/manifests/ganglia.pp b/manifests/ganglia.pp
index b524857..c3d2eac 100644
--- a/manifests/ganglia.pp
+++ b/manifests/ganglia.pp
@@ -708,9 +708,9 @@
# require ganglia::web
if $description {
- $view_name = $name
- } else {
$view_name = $description
+ } else {
+ $view_name = $name
}
file { "${conf_dir}/view_${name}.json":
ensure => $ensure,
--
To view, visit https://gerrit.wikimedia.org/r/170160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e8ded3abd71ee462e29893455678859410eb216
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: QChris <christ...@quelltextlich.at>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
