Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/170304
Change subject: Always return a value on SpecialRandomInCategory::onSubmit ...................................................................... Always return a value on SpecialRandomInCategory::onSubmit false usually indicates no submission was attempted in HTMLForms Change-Id: I11d1d3e627a9e9bc3ed77a70c1b4f7456011c772 --- M includes/specials/SpecialRandomInCategory.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/04/170304/1 diff --git a/includes/specials/SpecialRandomInCategory.php b/includes/specials/SpecialRandomInCategory.php index 570ab3b..f9e03ab 100644 --- a/includes/specials/SpecialRandomInCategory.php +++ b/includes/specials/SpecialRandomInCategory.php @@ -117,7 +117,7 @@ return Status::newFatal( $msg ); } elseif ( !$this->category ) { - return; // no data sent + return false; // no data sent } $title = $this->getRandomTitle(); -- To view, visit https://gerrit.wikimedia.org/r/170304 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I11d1d3e627a9e9bc3ed77a70c1b4f7456011c772 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits