Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/170320
Change subject: Only test Jenkins jobs existence on gate-and-submit ...................................................................... Only test Jenkins jobs existence on gate-and-submit Whenever someone propose a change that introduces new jobs, the integration-zuul-layoutvalidation jobs fails because the job are not found in Jenkins. That is to be expected since the change is proposing to add them. The failure has confused a few people recently. I originally introduced it to prevent Zuul configuration changes to be merged/deployed while jobs are not deployed. Remove the validation against Jenkins when patches are proposed (test pipeline). On gate, use a new job that does assert the jobs exists. This way, if someone forget to deploy the jobs but +2 the change, it will not land remembering people to do the deploy. Change-Id: Id8f8eecc5ded1a77b120df090db9100f142b99d9 --- M jjb/integration.yaml M zuul/layout.yaml 2 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/config refs/changes/20/170320/1 diff --git a/jjb/integration.yaml b/jjb/integration.yaml index 4951949..596be58 100644 --- a/jjb/integration.yaml +++ b/jjb/integration.yaml @@ -31,10 +31,19 @@ - zuul builders: - shell: | + /usr/local/bin/zuul-server -l "$WORKSPACE"/zuul/layout.yaml + +- job-template: + name: 'integration-zuul-layoutvalidation-gate' + node: gallium # it is running Zuul + defaults: use-remote-zuul + concurrent: true + triggers: + - zuul + builders: + - shell: | rm -f jenkins_jobs.txt python /srv/deployment/integration/slave-scripts/bin/jenkins-jobs-list.py > jenkins_jobs.txt - - # FIXME change path whenever we have zuul packaged. /usr/local/bin/zuul-server -t jenkins_jobs.txt -l "$WORKSPACE"/zuul/layout.yaml # Job for Zuul configuration validation diff --git a/zuul/layout.yaml b/zuul/layout.yaml index c3e43f7..4a66e4f 100644 --- a/zuul/layout.yaml +++ b/zuul/layout.yaml @@ -1832,7 +1832,7 @@ - integration-config-yamllint - integration-jjb-config-diff - integration-zuul-layoutdiff - - integration-zuul-layoutvalidation + - integration-zuul-layoutvalidation-gate - name: integration/jenkins template: -- To view, visit https://gerrit.wikimedia.org/r/170320 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8f8eecc5ded1a77b120df090db9100f142b99d9 Gerrit-PatchSet: 1 Gerrit-Project: integration/config Gerrit-Branch: master Gerrit-Owner: Hashar <has...@free.fr> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits