Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/170322
Change subject: Remove unset( $jenkins_job_name ) from entry point ...................................................................... Remove unset( $jenkins_job_name ) from entry point this variable is undefined. in the past, to add extra phpunit arguments, we added $jenkins_job_name = getenv( 'JOB_NAME' ); we are not setting it now like that so it's pointless to unset it. Change-Id: I0299ac285f089861ee2adbbde4804bcc500747e4 --- M Wikibase.php 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/22/170322/1 diff --git a/Wikibase.php b/Wikibase.php index 269a8c1..b26f47a 100644 --- a/Wikibase.php +++ b/Wikibase.php @@ -36,6 +36,3 @@ die( "This entry point is for use by the Jenkins testing framework only.\n" . "Use repo/Wikibase.php resp. client/WikibaseClient.php instead.\n" ); } - -// Avoid polluting the global namespace -unset( $jenkins_job_name ); \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/170322 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0299ac285f089861ee2adbbde4804bcc500747e4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits