jenkins-bot has submitted this change and it was merged.

Change subject: Disable CodeEditor on mobile
......................................................................


Disable CodeEditor on mobile

Disabled on our known android/iphone/ipod UAs, because of Bug 55345.

Change-Id: I8c5377889c349df14d43803fecaab09d7554e97a
---
M modules/jquery.codeEditor.js
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index 42a7979..bdb4ef5 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -10,7 +10,12 @@
                 *  Compatability map
                 */
                browsers: {
-                       msie: [['>=', 8]]
+                       msie: [['>=', 8]],
+                       // Input on mobile is broken: bug 55345
+                       // https://github.com/ajaxorg/ace/issues/37
+                       ipod: false,
+                       iphone: false,
+                       android: false
                },
                /**
                 * Configuration

-- 
To view, visit https://gerrit.wikimedia.org/r/141385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c5377889c349df14d43803fecaab09d7554e97a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to