[MediaWiki-commits] [Gerrit] Ensure that build works with the updated java-mwapi. - change (apps...wikipedia)

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/170432

Change subject: Ensure that build works with the updated java-mwapi.
......................................................................

Ensure that build works with the updated java-mwapi.

There were a few "throws" declarations missing that are now required.

Change-Id: Ie5520cf995219fbd540d6ccaf076d3313e7c61e3
---
M wikipedia/src/main/java/org/wikipedia/ApiTask.java
M wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountTask.java
M wikipedia/src/main/java/org/wikipedia/editing/DoEditTask.java
M wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java
4 files changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/32/170432/1

diff --git a/wikipedia/src/main/java/org/wikipedia/ApiTask.java 
b/wikipedia/src/main/java/org/wikipedia/ApiTask.java
index f7f6482..8f3aae8 100644
--- a/wikipedia/src/main/java/org/wikipedia/ApiTask.java
+++ b/wikipedia/src/main/java/org/wikipedia/ApiTask.java
@@ -1,6 +1,7 @@
 package org.wikipedia;
 
 import org.mediawiki.api.json.Api;
+import org.mediawiki.api.json.ApiException;
 import org.mediawiki.api.json.ApiResult;
 import org.mediawiki.api.json.RequestBuilder;
 import org.wikipedia.concurrency.SaneAsyncTask;
@@ -19,7 +20,7 @@
         return processResult(result);
     }
 
-    protected ApiResult makeRequest(RequestBuilder builder) {
+    protected ApiResult makeRequest(RequestBuilder builder) throws 
ApiException {
         return builder.get();
     }
 
diff --git 
a/wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountTask.java 
b/wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountTask.java
index 47cb6eb..3a14641 100644
--- a/wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountTask.java
+++ b/wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountTask.java
@@ -3,6 +3,7 @@
 import android.content.Context;
 import org.json.JSONObject;
 import org.mediawiki.api.json.Api;
+import org.mediawiki.api.json.ApiException;
 import org.mediawiki.api.json.ApiResult;
 import org.mediawiki.api.json.RequestBuilder;
 import org.wikipedia.ApiTask;
@@ -39,7 +40,7 @@
     }
 
     @Override
-    protected ApiResult makeRequest(RequestBuilder builder) {
+    protected ApiResult makeRequest(RequestBuilder builder) throws 
ApiException {
         return builder.post();
     }
 
diff --git a/wikipedia/src/main/java/org/wikipedia/editing/DoEditTask.java 
b/wikipedia/src/main/java/org/wikipedia/editing/DoEditTask.java
index 6c8c13c..2c650b7 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/DoEditTask.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/DoEditTask.java
@@ -3,6 +3,7 @@
 import android.content.Context;
 import org.json.JSONObject;
 import org.mediawiki.api.json.Api;
+import org.mediawiki.api.json.ApiException;
 import org.mediawiki.api.json.ApiResult;
 import org.mediawiki.api.json.RequestBuilder;
 import org.wikipedia.ApiTask;
@@ -41,7 +42,7 @@
     }
 
     @Override
-    protected ApiResult makeRequest(RequestBuilder builder) {
+    protected ApiResult makeRequest(RequestBuilder builder) throws 
ApiException {
         return builder.post(); // Editing requires POST requests
     }
 
diff --git a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java 
b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java
index 0678b92..2eab0e1 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java
@@ -2,6 +2,7 @@
 
 import android.content.Context;
 import org.mediawiki.api.json.Api;
+import org.mediawiki.api.json.ApiException;
 import org.mediawiki.api.json.ApiResult;
 import org.mediawiki.api.json.RequestBuilder;
 import org.wikipedia.ApiTask;
@@ -34,7 +35,7 @@
     }
 
     @Override
-    protected ApiResult makeRequest(RequestBuilder builder) {
+    protected ApiResult makeRequest(RequestBuilder builder) throws 
ApiException {
         return builder.post();
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/170432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5520cf995219fbd540d6ccaf076d3313e7c61e3
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits