Physikerwelt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/170643

Change subject: Disable overwriting of the fallback image
......................................................................

Disable overwriting of the fallback image

The style information for the fallback image is quite sophisticated
and should not be changed.

Bug: 72626
Change-Id: I553cf7209d87517b8c8841cc25df74ebd4c683f4
---
M MathMathML.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Math 
refs/changes/43/170643/1

diff --git a/MathMathML.php b/MathMathML.php
index b440cf2..9f3619a 100644
--- a/MathMathML.php
+++ b/MathMathML.php
@@ -383,10 +383,9 @@
                $style = 'background-image: url(\''. $url. '\'); 
background-repeat: no-repeat; background-size: 100% 100%;';
                $this->correctSvgStyle( $this->getSvg(), $style );
                if ( $class ) { $attribs['class'] = $class; }
-               if ( $style ) { $attribs['style'] = $style; }
                // Don't use an empty span, as that is going to be stripped by 
HTML tidy
                // when enabled (which is true in production).
-               return Xml::element( 'meta', $this->getAttributes( 'span', 
$attribs , array( 'aria-hidden' => 'true' ) ) );
+               return Xml::element( 'meta', $this->getAttributes( 'span', 
$attribs , array( 'aria-hidden' => 'true', 'style' => $style ) ) );
        }
 
 
@@ -439,6 +438,7 @@
                $output .= Xml::tags( $element, array( 'class' => 
$this->getClassName(), 'style' => 'display: none;'  ), $mml );
                $output .= $this->getFallbackImage( ) . "\n";
                $output .= HTML::closeElement( $element );
+               wfDebugLog("Math","new output".$this->getFallbackImage( ));
                return $output;
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/170643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I553cf7209d87517b8c8841cc25df74ebd4c683f4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt <w...@physikerwelt.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to