[MediaWiki-commits] [Gerrit] Only log theme change events if the theme was actually changed. - change (apps...wikipedia)

[Dbrant (Code Review)]

Dbrant has submitted this change and it was merged.

Change subject: Only log theme change events if the theme was actually changed.
......................................................................


Only log theme change events if the theme was actually changed.

Right now the MobileWikiAppAppearanceSettings schema records each tap on the
dialogue for changing themes. This patch changes this, so that only taps that
result in an actual change are logged (e.g. trying to change from light mode
to light mode is not logged).

Change-Id: I11946d63514957b06947d4870e591f2c2b03e643
---
M wikipedia/src/main/java/org/wikipedia/theme/ThemeChooserDialog.java
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved



diff --git 
a/wikipedia/src/main/java/org/wikipedia/theme/ThemeChooserDialog.java 
b/wikipedia/src/main/java/org/wikipedia/theme/ThemeChooserDialog.java
index 0ab196d..00d679d 100644
--- a/wikipedia/src/main/java/org/wikipedia/theme/ThemeChooserDialog.java
+++ b/wikipedia/src/main/java/org/wikipedia/theme/ThemeChooserDialog.java
@@ -85,8 +85,11 @@
         buttonThemeLight.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View view) {
-                funnel.logThemeChange(app.getCurrentTheme(), 
WikipediaApp.THEME_LIGHT);
-                app.setCurrentTheme(WikipediaApp.THEME_LIGHT);
+                //Only change the theme to light mode and log change if user 
is not on light mode
+                if (app.getCurrentTheme() != WikipediaApp.THEME_LIGHT) {
+                    funnel.logThemeChange(app.getCurrentTheme(), 
WikipediaApp.THEME_LIGHT);
+                    app.setCurrentTheme(WikipediaApp.THEME_LIGHT);
+                }
             }
         });
 
@@ -94,8 +97,11 @@
         buttonThemeDark.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View view) {
-                funnel.logThemeChange(app.getCurrentTheme(), 
WikipediaApp.THEME_DARK);
-                app.setCurrentTheme(WikipediaApp.THEME_DARK);
+                //Only change the theme to dark mode and log change if user is 
not on dark mode
+                if (app.getCurrentTheme() != WikipediaApp.THEME_DARK) {
+                    funnel.logThemeChange(app.getCurrentTheme(), 
WikipediaApp.THEME_DARK);
+                    app.setCurrentTheme(WikipediaApp.THEME_DARK);
+                }
             }
         });
 

-- 
To view, visit https://gerrit.wikimedia.org/r/171152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11946d63514957b06947d4870e591f2c2b03e643
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <dga...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits