Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171446
Change subject: Hygiene: Extend ReferencesDrawerBeta defaults
......................................................................
Hygiene: Extend ReferencesDrawerBeta defaults
Don't duplicate code.
Change-Id: I3c1a976655ad0b987d24d6aa82ff3c7efc50b9dd
---
M javascripts/modules/references/ReferencesDrawerBeta.js
1 file changed, 4 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/46/171446/1
diff --git a/javascripts/modules/references/ReferencesDrawerBeta.js
b/javascripts/modules/references/ReferencesDrawerBeta.js
index a2dead2..7d9632e 100644
--- a/javascripts/modules/references/ReferencesDrawerBeta.js
+++ b/javascripts/modules/references/ReferencesDrawerBeta.js
@@ -1,4 +1,4 @@
-( function ( M ) {
+( function ( M, $ ) {
var ReferencesDrawer = M.require( 'modules/references/ReferencesDrawer'
),
Icon = M.require( 'Icon' ),
ReferencesDrawerBeta;
@@ -9,19 +9,15 @@
* @extends ReferencesDrawer
*/
ReferencesDrawerBeta = ReferencesDrawer.extend( {
- defaults: {
- cancelButton: new Icon( {
- name: 'cancel-light', additionalClassNames:
'cancel',
- label: mw.msg( 'mobile-frontend-overlay-close' )
- } ).toHtmlString(),
+ defaults: $.extend( ReferencesDrawer.prototype.defaults, {
citation: new Icon( {
name: 'citation', additionalClassNames: 'text',
hasText: true,
label: mw.msg(
'mobile-frontend-references-citation' )
} ).toHtmlString()
- },
+ } ),
template: mw.template.get( 'mobile.references.beta',
'DrawerBeta.hogan' )
} );
M.define( 'modules/references/ReferencesDrawerBeta',
ReferencesDrawerBeta );
-}( mw.mobileFrontend ) );
+}( mw.mobileFrontend, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/171446
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c1a976655ad0b987d24d6aa82ff3c7efc50b9dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
