Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171464
Change subject: Show category items as red if they don't have description pages
......................................................................
Show category items as red if they don't have description pages
Also fix some lies I wrote in related code/docs
Bug: 65517
Change-Id: Iafacee7d8e460913d84808fe38ecc8da4a1817c0
---
M modules/ve-mw/init/ve.init.mw.LinkCache.js
M modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
M modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
M modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
4 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/64/171464/1
diff --git a/modules/ve-mw/init/ve.init.mw.LinkCache.js
b/modules/ve-mw/init/ve.init.mw.LinkCache.js
index c3ea0dd..5df146f 100644
--- a/modules/ve-mw/init/ve.init.mw.LinkCache.js
+++ b/modules/ve-mw/init/ve.init.mw.LinkCache.js
@@ -86,7 +86,7 @@
/**
* Requests information about the title, then adds classes to the
provided element as appropriate.
*
- * @param {string} title Defaults to 'href' attribute of $element
+ * @param {string} title
* @param {jQuery} $element Element to style
*/
ve.init.mw.LinkCache.prototype.styleElement = function ( title,
$element ) {
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
index 2dc0e57..b3d1d4e 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryItemWidget.css
@@ -55,6 +55,10 @@
color: #333;
}
+.ve-ui-mwCategoryItemWidget-label.new {
+ color: #BA0000;
+}
+
.ve-ui-mwCategoryItemWidget-button:active {
border-color: #ddd;
box-shadow: inset 0 1px 4px 0 rgba(0, 0, 0, 0.07);
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
index 08905e1..80813d3 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
@@ -49,6 +49,15 @@
this.$label
.addClass( 've-ui-mwCategoryItemWidget-label' )
.text( config.redirectTo || this.value );
+ if ( config.redirectTo ) {
+ ve.init.platform.linkCache.styleElement( mw.Title.newFromText(
+ config.redirectTo,
+ mw.config.get( 'wgNamespaceIds' ).category
+ ).getPrefixedText(), this.$label );
+ } else {
+ ve.init.platform.linkCache.styleElement( this.name, this.$label
);
+ }
+
this.$categoryItem
.addClass( 've-ui-mwCategoryItemWidget-button' )
.append( this.$label, this.$indicator );
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
index d56f806..5509b9c 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
@@ -206,7 +206,7 @@
if ( result && result.query && result.query.pages ) {
$.each( result.query.pages, function ( index, pageInfo
) {
linkCacheUpdate[pageInfo.title] = {
- missing: false,
+ missing:
Object.prototype.hasOwnProperty.call( pageInfo, 'missing' ),
hidden: pageInfo.pageprops &&
Object.prototype.hasOwnProperty.call( pageInfo.pageprops, 'hiddencat' )
};
--
To view, visit https://gerrit.wikimedia.org/r/171464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafacee7d8e460913d84808fe38ecc8da4a1817c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
