Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/171583
Change subject: Add the ability to apply a different duration sampling factor to loggedin users ...................................................................... Add the ability to apply a different duration sampling factor to loggedin users Change-Id: I10fc042ddf50f02e1a86711621b66c14fc981311 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/978 --- M MultimediaViewer.php M MultimediaViewerHooks.php M resources/mmv/logging/mmv.logging.DurationLogger.js 3 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/83/171583/1 diff --git a/MultimediaViewer.php b/MultimediaViewer.php index 5822e44..9aa2ae9 100644 --- a/MultimediaViewer.php +++ b/MultimediaViewer.php @@ -35,6 +35,16 @@ $wgMediaViewerDurationLoggingSamplingFactor = false; } +if ( !isset( $wgMediaViewerDurationLoggingLoggedinSamplingFactor ) ) { + /** + * If set, records loading times via EventLogging with factor specific to loggedin users. + * A value of 1000 means there will be an 1:1000 chance to log the duration event. + * False if unset. + * @var int|bool + */ + $wgMediaViewerDurationLoggingLoggedinSamplingFactor = false; +} + if ( !isset( $wgMediaViewerAttributionLoggingSamplingFactor ) ) { /** * If set, records whether image attribution data was available. A value of 1000 means there will be an diff --git a/MultimediaViewerHooks.php b/MultimediaViewerHooks.php index 53c17d1..bf6d36f 100644 --- a/MultimediaViewerHooks.php +++ b/MultimediaViewerHooks.php @@ -140,14 +140,16 @@ */ public static function resourceLoaderGetConfigVars( &$vars ) { global $wgMediaViewerActionLoggingSamplingFactorMap, $wgNetworkPerformanceSamplingFactor, - $wgMediaViewerDurationLoggingSamplingFactor, $wgMediaViewerAttributionLoggingSamplingFactor, - $wgMediaViewerDimensionLoggingSamplingFactor, $wgMediaViewerIsInBeta, $wgMediaViewerUseThumbnailGuessing; + $wgMediaViewerDurationLoggingSamplingFactor, $wgMediaViewerDurationLoggingLoggedinSamplingFactor, + $wgMediaViewerAttributionLoggingSamplingFactor, $wgMediaViewerDimensionLoggingSamplingFactor, + $wgMediaViewerIsInBeta, $wgMediaViewerUseThumbnailGuessing; $vars['wgMultimediaViewer'] = array( 'infoLink' => self::$infoLink, 'discussionLink' => self::$discussionLink, 'helpLink' => self::$helpLink, 'useThumbnailGuessing' => (bool)$wgMediaViewerUseThumbnailGuessing, 'durationSamplingFactor' => $wgMediaViewerDurationLoggingSamplingFactor, + 'durationSamplingFactorLoggedin' => $wgMediaViewerDurationLoggingLoggedinSamplingFactor, 'networkPerformanceSamplingFactor' => $wgNetworkPerformanceSamplingFactor, 'actionLoggingSamplingFactorMap' => $wgMediaViewerActionLoggingSamplingFactorMap, 'attributionSamplingFactor' => $wgMediaViewerAttributionLoggingSamplingFactor, diff --git a/resources/mmv/logging/mmv.logging.DurationLogger.js b/resources/mmv/logging/mmv.logging.DurationLogger.js index 1a769d7..46e8555 100644 --- a/resources/mmv/logging/mmv.logging.DurationLogger.js +++ b/resources/mmv/logging/mmv.logging.DurationLogger.js @@ -38,6 +38,11 @@ */ L.samplingFactor = mw.config.get( 'wgMultimediaViewer' ).durationSamplingFactor; + // If a sampling factor specific to loggedin users is set and we're logged in, apply it + if ( mw.config.get( 'wgMultimediaViewer' ).durationSamplingFactorLoggedin && !mw.user.isAnon() ) { + L.samplingFactor = mw.config.get( 'wgMultimediaViewer' ).durationSamplingFactorLoggedin; + } + /** * @override * @inheritdoc -- To view, visit https://gerrit.wikimedia.org/r/171583 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I10fc042ddf50f02e1a86711621b66c14fc981311 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gilles <gdu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
