Trevor Parscal has submitted this change and it was merged. Change subject: Fix ve.batchSplice() to behave in line with docs ......................................................................
Fix ve.batchSplice() to behave in line with docs * Actually return the spliced data like the docs claim we do * Remove false claim that offset can be negative * Add that data=[] && remove=0 is invalid; native splice() doesn't allow this, and there is a case where we call native splice() directly * Add tests Change-Id: I90e77c1b22ea1c36cb61e89ea47831885a0b1cb9 --- M modules/ve/test/ve.test.js M modules/ve/ve.js 2 files changed, 39 insertions(+), 7 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30749 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90e77c1b22ea1c36cb61e89ea47831885a0b1cb9 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
