Yuvipanda has submitted this change and it was merged.
Change subject: udpprofile: Fix pyflakes warnings
......................................................................
udpprofile: Fix pyflakes warnings
Change-Id: Ifa5d1b3f733fef02be1e1095ed72af28a6398d6a
---
M udpprofile/profile-stats-logger.py
M udpprofile/web/admin.py
M udpprofile/web/extractprofile.py
M udpprofile/web/pcache-hit-rate.py
M udpprofile/web/pcache-request-rate.py
M udpprofile/web/report.py
6 files changed, 2 insertions(+), 11 deletions(-)
Approvals:
Yuvipanda: Looks good to me, approved
jenkins-bot: Verified
diff --git a/udpprofile/profile-stats-logger.py
b/udpprofile/profile-stats-logger.py
index e3a68b3..15fea90 100755
--- a/udpprofile/profile-stats-logger.py
+++ b/udpprofile/profile-stats-logger.py
@@ -3,7 +3,6 @@
import math
import os
import os.path
-import pprint
import sys
import time
diff --git a/udpprofile/web/admin.py b/udpprofile/web/admin.py
index 33fefe0..694a21a 100644
--- a/udpprofile/web/admin.py
+++ b/udpprofile/web/admin.py
@@ -39,8 +39,8 @@
if 'sample' in form and authed:
del store[form['sample']]
elif form['action'] == 'clear' and authed:
- from socket import *
- sock = socket(AF_INET,SOCK_DGRAM)
+ import socket
+ sock = socket.socket(socket.AF_INET,socket.SOCK_DGRAM)
sock.sendto('-truncate',(config.host,config.port))
elif form['action'] == 'take' and authed:
from extractprofile import SocketProfile
diff --git a/udpprofile/web/extractprofile.py b/udpprofile/web/extractprofile.py
index 888f1dc..5696bb5 100755
--- a/udpprofile/web/extractprofile.py
+++ b/udpprofile/web/extractprofile.py
@@ -5,12 +5,9 @@
# Copyright (c) 2006 Domas Mituzas
-import sys
-import os
import socket
import xml.sax
-from xml.sax import saxutils
from xml.sax import make_parser
from xml.sax.handler import feature_namespaces
diff --git a/udpprofile/web/pcache-hit-rate.py
b/udpprofile/web/pcache-hit-rate.py
index dc6d9e7..8b28741 100755
--- a/udpprofile/web/pcache-hit-rate.py
+++ b/udpprofile/web/pcache-hit-rate.py
@@ -1,9 +1,7 @@
#!/usr/bin/python
import cgi
import cgitb
-import os
import rrdtool
-import sys
cgitb.enable()
diff --git a/udpprofile/web/pcache-request-rate.py
b/udpprofile/web/pcache-request-rate.py
index 6c69fd4..84a4812 100755
--- a/udpprofile/web/pcache-request-rate.py
+++ b/udpprofile/web/pcache-request-rate.py
@@ -1,9 +1,7 @@
#!/usr/bin/python
import cgi
import cgitb
-import os
import rrdtool
-import sys
cgitb.enable()
diff --git a/udpprofile/web/report.py b/udpprofile/web/report.py
index f1436df..ed3d1b8 100755
--- a/udpprofile/web/report.py
+++ b/udpprofile/web/report.py
@@ -16,7 +16,6 @@
import cgitb
cgitb.enable()
-import socket
import shelve
print "Content-type: text/html"
--
To view, visit https://gerrit.wikimedia.org/r/169256
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa5d1b3f733fef02be1e1095ed72af28a6398d6a
Gerrit-PatchSet: 1
Gerrit-Project: operations/software
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt <[email protected]>
Gerrit-Reviewer: Asher <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
