jenkins-bot has submitted this change and it was merged.
Change subject: Initialize context's $element as hidden
......................................................................
Initialize context's $element as hidden
this.visible is set to false, so the view should be hidden too.
This was also causing a scrolling issue on load in Chrome.
Change-Id: I2662df89618efd2ad1a9032f89af420e73d96fbd
(cherry picked from commit 1582bab9cbaa6889a6055c62d345d5fc27854cd7)
---
M src/ui/ve.ui.Context.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/ve.ui.Context.js b/src/ui/ve.ui.Context.js
index a7e7e38..76a5554 100644
--- a/src/ui/ve.ui.Context.js
+++ b/src/ui/ve.ui.Context.js
@@ -36,7 +36,9 @@
this.menu.connect( this, { choose: 'onContextItemChoose' } );
// Initialization
- this.$element.addClass( 've-ui-context' );
+ // Hide element using $.hide() not this.toggle as child implementations
+ // of toggle may require the instance to be fully constructed before
running.
+ this.$element.addClass( 've-ui-context' ).hide();
this.menu.toggle( false );
this.inspectors.$element.addClass( 've-ui-context-inspectors' );
};
--
To view, visit https://gerrit.wikimedia.org/r/173059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2662df89618efd2ad1a9032f89af420e73d96fbd
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.25wmf8
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
