Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173107
Change subject: mark new banner controller dependencies as mobile-ready
......................................................................
mark new banner controller dependencies as mobile-ready
Change-Id: I1ecdc6b966d0475e768d59e4944afebb9ed583fd
---
M CentralNotice.modules.php
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/07/173107/1
diff --git a/CentralNotice.modules.php b/CentralNotice.modules.php
index c631063..d6bcd40 100644
--- a/CentralNotice.modules.php
+++ b/CentralNotice.modules.php
@@ -132,12 +132,14 @@
// 'position' => 'top',
// 'dependencies' => array( 'ext.centralNotice.bannerController.lib' )
'class' => 'CNBannerChoiceDataResourceLoaderModule'
+ 'targets' => array( 'desktop', 'mobile' ),
);
$wgResourceModules[ 'ext.centralNotice.bannerController.lib' ] = array(
'localBasePath' => $dir . '/modules/ext.centralNotice.bannerController',
'remoteExtPath' =>
'CentralNotice/modules/ext.centralNotice.bannerController',
'scripts' => 'bannerController.lib.js',
'position' => 'top'
+ 'targets' => array( 'desktop', 'mobile' ),
);
$wgResourceModules[ 'ext.centralNotice.adminUi.campaignManager' ] = array(
'localBasePath' => $dir . '/modules',
--
To view, visit https://gerrit.wikimedia.org/r/173107
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ecdc6b966d0475e768d59e4944afebb9ed583fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
