Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173796
Change subject: Fix editing of ranks
......................................................................
Fix editing of ranks
Bug: 73307
Change-Id: I9e48cc31b95b4f4a5fc1a81be669064f49bcd9c0
(cherry picked from commit 555dfa378210e72d7aba8490f9449c3c41e3ed38)
---
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/96/173796/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index ee61459..0576f75 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -519,7 +519,9 @@
function stopEditing() {
self._isInEditMode = false;
- self._claimview.stopEditing( dropValue );
+ // If the claimview has it's initial value, it
refuses to leave edit mode.
+ // Set dropValue = true in this case, so that
it really leaves edit mode.
+ self._claimview.stopEditing(
self._claimview.isInitialValue() || dropValue );
self.enable();
self.element.removeClass( 'wb-edit' );
--
To view, visit https://gerrit.wikimedia.org/r/173796
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e48cc31b95b4f4a5fc1a81be669064f49bcd9c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf8
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Adrian Lang <adrian.l...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
