jenkins-bot has submitted this change and it was merged.
Change subject: Fixed value caching in snakview
......................................................................
Fixed value caching in snakview
broke in change Iafc2ed96df9f4a36b87ea9217eddc653fd3c4b9c when adapting to the
new JS data model
Change-Id: I693f32db6c61bbe42322875d27944c5460340a77
---
M lib/resources/jquery.wikibase/snakview/snakview.js
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
Jeroen De Dauw: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/snakview/snakview.js
b/lib/resources/jquery.wikibase/snakview/snakview.js
index 2a50acb..aa6c4d9 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.js
@@ -702,8 +702,13 @@
snaktype: snakType
};
- if( this._cachedValues[snakType] ) {
- $.extend( changes, this._cachedValues[snakType]
);
+ if( this._cachedValues[snakType] &&
this._cachedValues[snakType].datavalue ) {
+ $.extend( changes, {
+ datavalue: {
+ type:
this._cachedValues[snakType].datavalue.getType(),
+ value:
this._cachedValues[snakType].datavalue.toJSON()
+ }
+ } );
}
this._updateValue( changes );
--
To view, visit https://gerrit.wikimedia.org/r/173833
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I693f32db6c61bbe42322875d27944c5460340a77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
