jenkins-bot has submitted this change and it was merged.
Change subject: Don't always use updateDimensionsDebounced
......................................................................
Don't always use updateDimensionsDebounced
If the menu is shown but only moved after debounce, then it
visibly jumps from it's old position.
Bug: 73242
Change-Id: I7db94ec54cc2613a1a0cb3e86cf3a3724030901e
---
M src/ui/ve.ui.DesktopContext.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/ve.ui.DesktopContext.js b/src/ui/ve.ui.DesktopContext.js
index f6a30c4..01d330c 100644
--- a/src/ui/ve.ui.DesktopContext.js
+++ b/src/ui/ve.ui.DesktopContext.js
@@ -178,7 +178,8 @@
if ( this.inspector ) {
this.inspectors.updateWindowSize( this.inspector );
}
- this.updateDimensionsDebounced();
+ // updateDimensionsDebounced is not necessary here and causes a
movement flicker
+ this.updateDimensions();
} else if ( this.inspector ) {
this.inspector.close();
}
--
To view, visit https://gerrit.wikimedia.org/r/173804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7db94ec54cc2613a1a0cb3e86cf3a3724030901e
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
