Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173929
Change subject: [BrowserTest] minor violation of Page Object design pattern
......................................................................
[BrowserTest] minor violation of Page Object design pattern
and RSPec syntax also fixed
Change-Id: I2bbaf460f6ddae708ea243064dd9a596bdd006f1
---
M modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
2 files changed, 2 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/29/173929/1
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
index 64bef6f..e7c79cf 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
@@ -1,8 +1,5 @@
Given(/^I can see the Link User Inteface$/) do
- on(VisualEditorPage) do |page|
- page.ve_link_ui_element.when_present
- page.ve_link_ui.should match Regexp.escape("Link")
- end
+ on(VisualEditorPage).ve_link_ui_element.when_present
end
When(/^I click Done to close Link User Interface$/) do
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index eda2748..1df8a63 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -177,7 +177,7 @@
div(:extension_reference, class: "ve-ui-mwReferenceResultWidget-shield",
frame: frame)
span(:existing_reference, text: "Use an existing reference", frame: frame)
a(:remove_template, title: "Remove template", frame: frame)
- div(:ve_link_ui, class: "oo-ui-window-head", frame: frame)
+ div(:ve_link_ui, class: "oo-ui-window-head", text: /Link/, frame: frame)
div(:suggestion_list, class: "ve-ui-mwTitleInputWidget-menu")
span(:another_save_page, class: "oo-ui-labelElement-label", text: "Save
page", frame: frame)
text_field(:link_textfield, index: 0, frame: frame)
--
To view, visit https://gerrit.wikimedia.org/r/173929
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bbaf460f6ddae708ea243064dd9a596bdd006f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
