EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174023

Change subject: Only prevent caching of POST requests via API
......................................................................

Only prevent caching of POST requests via API

Change-Id: Ie688844c59adf99559a88af3f251226f81747556
---
M modules/engine/misc/flow-api.js
1 file changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/23/174023/1

diff --git a/modules/engine/misc/flow-api.js b/modules/engine/misc/flow-api.js
index 474b170..bc1a372 100644
--- a/modules/engine/misc/flow-api.js
+++ b/modules/engine/misc/flow-api.js
@@ -45,14 +45,21 @@
                 * @returns {$.Deferred}
                 */
                function flowApiCall( params, method ) {
+                       var mwApi,
+                               $deferred = $.Deferred();
+
+                       // IE8 caches POST under some conditions, prevent that 
here.
+                       if ( method === "POST" ) {
+                               mwApi = new mw.Api( { ajax: { cache: false } } 
);
+                       } else {
+                               mwApi = new mw.Api();
+                       }
+
                        params = params || {};
                        // Server is using page instead of title
                        // @todo this should not be necessary
                        params.page = params.page || this.pageName || 
mw.config.get( 'wgPageName' );
                        method = method ? method.toUpperCase() : 'GET';
-
-                       var $deferred = $.Deferred(),
-                               mwApi = new mw.Api( { ajax: { cache: false } } 
);
 
                        if ( !params.action ) {
                                mw.flow.debug( '[FlowApi] apiCall error: 
missing action string', arguments );

-- 
To view, visit https://gerrit.wikimedia.org/r/174023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie688844c59adf99559a88af3f251226f81747556
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to