Bmansurov has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174037

Change subject: WIP: Use Istanbul for code coverage
......................................................................

WIP: Use Istanbul for code coverage

* Replace grunt-contrib-qunit with grunt-qunit-istanbul

Isn't working because of this issue:
https://github.com/asciidisco/grunt-qunit-istanbul/issues/31

Change-Id: Ib0d8dfc72f86ce3878f5d0b8943e1a38bf7b3703
---
M .gitignore
M Gruntfile.js
M package.json
3 files changed, 14 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/37/174037/1

diff --git a/.gitignore b/.gitignore
index dbd9cc8..e900ac6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,3 +13,4 @@
 composer.phar
 .DS_Store
 composer.lock
+tests/report
diff --git a/Gruntfile.js b/Gruntfile.js
index cb1b80d..dbe0315 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -10,7 +10,7 @@
 
        grunt.loadNpmTasks( 'grunt-contrib-jshint' );
        grunt.loadNpmTasks( 'grunt-jscs' );
-       grunt.loadNpmTasks( 'grunt-contrib-qunit' );
+       grunt.loadNpmTasks( 'grunt-qunit-istanbul' );
        grunt.loadNpmTasks( 'grunt-contrib-watch' );
        grunt.loadNpmTasks( 'grunt-notify' );
        grunt.loadNpmTasks( 'grunt-svg2png' );
@@ -45,7 +45,16 @@
                qunit: {
                        all: {
                                options: {
-                                       urls: [ '<%= URL 
%>Special:JavaScriptTest/qunit?useformat=mobile<%= QUNIT_FILTER %><%= 
QUNIT_MODULE %>' ]
+                                       urls: [ '<%= URL 
%>Special:JavaScriptTest/qunit?useformat=mobile<%= QUNIT_FILTER %><%= 
QUNIT_MODULE %>' ],
+                                       coverage: {
+                                               //baseUrl: '<%= URL 
%>Special:JavaScriptTest/qunit?useformat=mobile<%= QUNIT_FILTER %><%= 
QUNIT_MODULE %>',
+                                               src: [
+                                                       '<%= files.js %>',
+                                                       '!<%= files.jsExternals 
%>'
+                                               ],
+                                               instrumentedFiles: 
'tests/report/tmp',
+                                               htmlReport: 'tests/report'
+                                       }
                                }
                        }
                },
diff --git a/package.json b/package.json
index ed1bf35..a49d77f 100644
--- a/package.json
+++ b/package.json
@@ -17,7 +17,7 @@
                "grunt-jscs": "0.8.1",
                "js-beautify": "^1.5.4",
                "grunt-notify": "^0.3.1",
-               "grunt-contrib-qunit": "^0.5.2",
-               "grunt-contrib-watch": "0.6.1"
+               "grunt-contrib-watch": "0.6.1",
+               "grunt-qunit-istanbul": "^0.4.5"
        }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/174037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0d8dfc72f86ce3878f5d0b8943e1a38bf7b3703
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to