jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: Update mixin file to use single line comments ......................................................................
Hygiene: Update mixin file to use single line comments Since these are not valid CSS they do not turn up in the output. This makes debugging a lot easier as mixin files typically get included multiple times across less files. Change-Id: I5adacb277f18f782a8293285fd8f98e825f39734 --- M resources/src/mediawiki.less/mediawiki.mixins.less 1 file changed, 17 insertions(+), 21 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less b/resources/src/mediawiki.less/mediawiki.mixins.less index 4a87b74..c84c884 100644 --- a/resources/src/mediawiki.less/mediawiki.mixins.less +++ b/resources/src/mediawiki.less/mediawiki.mixins.less @@ -1,14 +1,12 @@ -/** - * Common LESS mixin library for MediaWiki - * - * By default the folder containing this file is included in $wgResourceLoaderLESSImportPaths, - * which makes this file importable by all less files via '@import "mediawiki.mixins";'. - * - * The mixins included below are considered a public interface for MediaWiki extensions. - * The signatures of parametrized mixins should be kept as stable as possible. - * - * See <http://lesscss.org/#-mixins> for more information about how to write mixins. - */ +// Common LESS mixin library for MediaWiki +// +// By default the folder containing this file is included in $wgResourceLoaderLESSImportPaths, +// which makes this file importable by all less files via '@import "mediawiki.mixins";'. +// +// The mixins included below are considered a public interface for MediaWiki extensions. +// The signatures of parametrized mixins should be kept as stable as possible. +// +// See <http://lesscss.org/#-mixins> for more information about how to write mixins. .background-image(@url) { background-image: e('/* @embed */') url(@url); @@ -31,16 +29,14 @@ background-image: linear-gradient( @startColor @startPos, @endColor @endPos ); // Standard } -/* - * SVG support using a transparent gradient to guarantee cross-browser - * compatibility (browsers able to understand gradient syntax support also SVG). - * http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique - * - * We use gzip compression, which means that it is okay to embed twice. - * - * We do not embed the fallback image on the assumption that the gain for old browsers - * is not worth the harm done to modern ones. - */ +// SVG support using a transparent gradient to guarantee cross-browser +// compatibility (browsers able to understand gradient syntax support also SVG). +// http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique +// +// We use gzip compression, which means that it is okay to embed twice. +// +// We do not embed the fallback image on the assumption that the gain for old browsers +// is not worth the harm done to modern ones. .background-image-svg(@svg, @fallback) { background-image: url(@fallback); background-image: -webkit-linear-gradient(transparent, transparent), e('/* @embed */') url(@svg); -- To view, visit https://gerrit.wikimedia.org/r/173669 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5adacb277f18f782a8293285fd8f98e825f39734 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: Bartosz Dziewoński <[email protected]> Gerrit-Reviewer: Jack Phoenix <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
