Ryasmeen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174587
Change subject: [BrowserTest]
......................................................................
[BrowserTest]
Adding cases to test categories in options.feature
Change-Id: I6fbe8bc170306c5f2942bf3c7e87f7a3ff661bb2
---
M modules/ve-mw/tests/browser/features/options.feature
M modules/ve-mw/tests/browser/features/step_definitions/options_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
3 files changed, 20 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/87/174587/1
diff --git a/modules/ve-mw/tests/browser/features/options.feature
b/modules/ve-mw/tests/browser/features/options.feature
index ad76931..8dc901b 100644
--- a/modules/ve-mw/tests/browser/features/options.feature
+++ b/modules/ve-mw/tests/browser/features/options.feature
@@ -18,4 +18,9 @@
Scenario: Page Settings
When I click Page Settings
Then I should see the options overlay
- And the options overlay should display Page Settings
\ No newline at end of file
+ And the options overlay should display Page Settings
+
+ Scenario: Categories
+ When I click Categories
+ Then I should see the options overlay
+ And the options overlay should display Categories
\ No newline at end of file
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/options_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/options_steps.rb
index ed0c7b7..a707368 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/options_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/options_steps.rb
@@ -2,6 +2,10 @@
on(VisualEditorPage).option_advanced_settings_element.when_present.click
end
+When(/^I click Categories$/) do
+ on(VisualEditorPage).options_categories_element.when_present.click
+end
+
When(/^I click Options$/) do
on(VisualEditorPage).options_in_hamburger_element.when_present.click
end
@@ -26,6 +30,14 @@
expect(on(VisualEditorPage).options_settings_content_element.text).to match
"Advanced settings"
end
+Then(/^the options overlay should display Categories$/) do
+ expect(on(VisualEditorPage).options_settings_content_element.text).to match
"Categories"
+end
+
Then(/^the options overlay should display Page Settings$/) do
expect(on(VisualEditorPage).options_settings_content_element.text).to match
"Page settings"
-end
\ No newline at end of file
+end
+
+
+
+
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 096d63f..6b8c965 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -83,6 +83,7 @@
checkbox(:minor_edit, id: "wpMinoredit")
div(:no_unused_fields, text: "No unused fields")
a(:new_link, class: "ve-ce-linkAnnotation ve-ce-mwInternalLinkAnnotation
new")
+ span(:options_categories, class: "oo-ui-tool-title-text", text: "Categories")
span(:options_in_hamburger, class: "oo-ui-tool-title", text: "Options")
span(:option_advanced_settings, class: "oo-ui-tool-title", text: "Advanced
settings")
span(:option_page_settings, class: "oo-ui-tool-title", text: "Page settings")
--
To view, visit https://gerrit.wikimedia.org/r/174587
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fbe8bc170306c5f2942bf3c7e87f7a3ff661bb2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Ryasmeen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
