Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174844
Change subject: LabelElement: Kill inline styles
......................................................................
LabelElement: Kill inline styles
We already toggle the .oo-ui-labelElement class on the parent element,
which makes it possible to apply different styles if the label is
visible or hidden.
This doesn't seem to cause any bad effects anywhere, but I tested it
only lightly.
Bug: 73156
Bug: 73677
Change-Id: I3a8fed4ebe4c0d56cb4cda25d42e30777ac035b7
---
M php/elements/LabelElement.php
M src/elements/LabelElement.js
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/44/174844/1
diff --git a/php/elements/LabelElement.php b/php/elements/LabelElement.php
index b9b75d1..4976206 100644
--- a/php/elements/LabelElement.php
+++ b/php/elements/LabelElement.php
@@ -52,7 +52,6 @@
}
}
- $this->target->setAttributes( !$label ? array( 'style' =>
'display: none;' ) : array() );
$this->element->toggleClasses( array( 'oo-ui-labelElement' ),
!!$this->label );
return $this;
diff --git a/src/elements/LabelElement.js b/src/elements/LabelElement.js
index 1d270ab..4595e44 100644
--- a/src/elements/LabelElement.js
+++ b/src/elements/LabelElement.js
@@ -129,5 +129,4 @@
} else {
this.$label.empty();
}
- this.$label.css( 'display', !label ? 'none' : '' );
};
--
To view, visit https://gerrit.wikimedia.org/r/174844
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a8fed4ebe4c0d56cb4cda25d42e30777ac035b7
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
