Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/174845
Change subject: Work around selection_weight issue in form chooser ...................................................................... Work around selection_weight issue in form chooser When the GatewayFormChooser finds multiple forms with equal relevance to the country, currency, and payment method, it selects based on selection_weight. However, if all forms have zero selection_weight, it throws them all out and returns an error. This commit gives the main worldpay form a non-zero selection_weight so the addition of equally-valid forms doesn't trigger the bug. Change-Id: Ifc82f030c4364a2616613d521e4fffbff183e252 --- M DonationInterfaceFormSettings.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/45/174845/1 diff --git a/DonationInterfaceFormSettings.php b/DonationInterfaceFormSettings.php index 1024103..3b81ed8 100644 --- a/DonationInterfaceFormSettings.php +++ b/DonationInterfaceFormSettings.php @@ -491,7 +491,7 @@ 'countries' => array( '+' => array( 'BE', 'FR', 'US' ) ), 'currencies' => array( '+' => 'ALL' ), 'payment_methods' => array( 'cc' => 'ALL' ), - 'selection_weight' => 0 + 'selection_weight' => 10 ); /************************* @@ -500,6 +500,7 @@ $worldpay_test_spec = array( 'file' => $form_dirs['worldpay'] . '/worldpay-test.html', + 'selection_weight' => 0, ) + $forms_whitelist['worldpay']; $forms_whitelist['wp-sn'] = $worldpay_test_spec; -- To view, visit https://gerrit.wikimedia.org/r/174845 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc82f030c4364a2616613d521e4fffbff183e252 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: fundraising/REL1_23 Gerrit-Owner: Ejegg <eeggles...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits