Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174963

Change subject: Fix tappable area of upload button
......................................................................

Fix tappable area of upload button

Previously not all button on Special:Uploads was tappable.
Cloaked elements are absolutely positioned to parent element.

Change-Id: I85c590f166b688201dce22a627319bb73fa7a431
---
M less/modules/uploads/PhotoUploaderButton.less
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/63/174963/1

diff --git a/less/modules/uploads/PhotoUploaderButton.less 
b/less/modules/uploads/PhotoUploaderButton.less
index 4f711eb..9328940 100644
--- a/less/modules/uploads/PhotoUploaderButton.less
+++ b/less/modules/uploads/PhotoUploaderButton.less
@@ -3,12 +3,18 @@
 @import "minerva.mixins";
 
 .ctaUploadPhoto {
+       // Ensure entire button is clickable
+       .button {
+               position: relative;
+       }
+
        // FIXME: Remove when mw-ui-icon in stable
        .icon-photo {
                background-position: left 10px center !important;
                padding-left: 44px;
        }
 
+       // FIXME: Rename to generic .button when mw-ui-icon in stable
        .mw-ui-icon-photo {
                display: table;
                position: relative;

-- 
To view, visit https://gerrit.wikimedia.org/r/174963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I85c590f166b688201dce22a627319bb73fa7a431
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to