jenkins-bot has submitted this change and it was merged. Change subject: [BrowserTest] rubocop change to an if() ......................................................................
[BrowserTest] rubocop change to an if() Change-Id: I5ae9ec4d94af88fa67ac8de58a38b6ea03b14acc --- M .rubocop_todo.yml M modules/ve-mw/tests/browser/features/support/language_screenshot.rb 2 files changed, 1 insertion(+), 8 deletions(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 8cf6572..cf265f1 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -36,8 +36,3 @@ Style/GlobalVars: Enabled: false -# Offense count: 1 -# Configuration parameters: MaxLineLength. -Style/IfUnlessModifier: - Enabled: false - diff --git a/modules/ve-mw/tests/browser/features/support/language_screenshot.rb b/modules/ve-mw/tests/browser/features/support/language_screenshot.rb index dad782d..29870f5 100644 --- a/modules/ve-mw/tests/browser/features/support/language_screenshot.rb +++ b/modules/ve-mw/tests/browser/features/support/language_screenshot.rb @@ -34,9 +34,7 @@ # It happens with some elements that an image goes off the screen a bit, # and chunky_png fails when this happens - if image.width < top_left_x + width - width = image.width - top_left_x - end + width = image.width - top_left_x if image.width < top_left_x + width image.crop!(top_left_x, top_left_y, width, height) image.save path -- To view, visit https://gerrit.wikimedia.org/r/174973 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ae9ec4d94af88fa67ac8de58a38b6ea03b14acc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
