Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175006
Change subject: Fix parens when setting geo data
......................................................................
Fix parens when setting geo data
Paren should close after regex, /then/ use empty array if falsy.
Existing code calls apply with null argument list with no GeoIP cookie
Change-Id: If08eda54488182df9a347c835f6f7938c8c0ff51
---
M modules/ext.centralNotice.bannerController/bannerController.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/06/175006/1
diff --git a/modules/ext.centralNotice.bannerController/bannerController.js
b/modules/ext.centralNotice.bannerController/bannerController.js
index 79eb55a..760af20 100644
--- a/modules/ext.centralNotice.bannerController/bannerController.js
+++ b/modules/ext.centralNotice.bannerController/bannerController.js
@@ -75,7 +75,7 @@
lon: lon && parseFloat( lon ),
af: af
};
- } ).apply( null, ( $.cookie( 'GeoIP' ) || '' ).match(
/([^:]*):([^:]*):([^:]*):([^:]*):([^;]*)/ || [] ) );
+ } ).apply( null, ( $.cookie( 'GeoIP' ) || '' ).match(
/([^:]*):([^:]*):([^:]*):([^:]*):([^;]*)/ ) || [] );
// FIXME Following the switch to client-side banner selection, it would
// make more sense for this to be defined in bannerController.lib.
Before
--
To view, visit https://gerrit.wikimedia.org/r/175006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If08eda54488182df9a347c835f6f7938c8c0ff51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
