Anomie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/175114

Change subject: Another PHP 5.3 bug
......................................................................

Another PHP 5.3 bug

Can't call a private method from inside the anonymous function either.

Change-Id: I7683c8965d3fe342387ad15b2a775af5763801dc
---
M includes/pages/VoterEligibilityPage.php
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SecurePoll 
refs/changes/14/175114/1

diff --git a/includes/pages/VoterEligibilityPage.php 
b/includes/pages/VoterEligibilityPage.php
index 60755fa..b8e7662 100644
--- a/includes/pages/VoterEligibilityPage.php
+++ b/includes/pages/VoterEligibilityPage.php
@@ -196,7 +196,11 @@
                return $names;
        }
 
-       private function saveList( $property, $names, $comment ) {
+       /**
+        * @todo Make this really private when we don't support PHP 5.3 anymore
+        * @private
+        */
+       public function saveList( $property, $names, $comment ) {
                global $wgSecurePollUseNamespace;
 
                $wikis = $this->election->getProperty( 'wikis' );

-- 
To view, visit https://gerrit.wikimedia.org/r/175114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7683c8965d3fe342387ad15b2a775af5763801dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SecurePoll
Gerrit-Branch: master
Gerrit-Owner: Anomie <bjor...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to